kacejot / xray-16 Goto Github PK

Project location: Externals/BugTrap

Feature requirements:

• BugTrap include directories should be automatically delivered to the target similar to target_include_directories command (If some target is linked with BugTrap, inlude files are added to this target build process automatically)
• BugTrap binaries should be exported as well: any target that links with BugTrap automatically links necessary libraries.
• custom target is added only for windows builds

Suggestions:
The best way is to use add_custom_target command similar to this example:

add_custom_target(
    ${PROJECT_NAME} ALL
    COMMAND ${BUILD_SCRIPT}
    WORKING_DIRECTORY ${PROJECT_SOURCE_DIR})

set_property(TARGET  ${PROJECT_NAME} PROPERTY IMPORTED_LOCATION "${BINDIR}/${LIB_NAME}")
target_include_directories(${PROJECT_NAME} PUBLIC ${PROJECT_HEADERS})

1. Remove problem_solver_inline.h
2. Move all header files to top
3. Remove inline qualifier
4. Decompose this class - it is overloaded

Rid of original repo readme.

Now the project has two build systems:

• CMake - works fine for Linux only
• Visual Studio solutions and projects

As far as CMake can generate VS projects, the best way will be to use CMake only.

Now CMake on Windows can't even generate project files because of next errors:

CMake Error at CMakeLists.txt:46 (install):
  install called with unknown mode $<TARGET_FILE:luabind>
Call Stack (most recent call first):
  Externals/CMakeLists.txt:3 (xr_install_file)


CMake Error at CMakeLists.txt:52 (install):
  install called with unknown mode $<TARGET_FILE:luabind>
Call Stack (most recent call first):
  Externals/CMakeLists.txt:3 (xr_install_file)

Error occurs here:

install($<TARGET_FILE:${tgt}>
    CONFIGURATIONS Debug
    RUNTIME DESTINATION Debug/)

and here:

install($<TARGET_FILE:${tgt}>
    CONFIGURATIONS Release
    RUNTIME DESTINATION Release/)

I think the reason is that install command requires mode to be filled (source).
So, I need to research which mode is the best one. FILES works, but who knows what the impact is.

graph_engine.h and problem_solver.h include each other, so I can't move all headers in problem_solver.h to the top