k8snetworkplumbingwg / accelerated-bridge-cni Goto Github PK

we should run code coverage as part of CI and have a badge that reports the state in README

What would you like to be added?

Add Makefile target to generate mocks

What is the use case for this feature / enhancement?

Extending unit tests when adding new functionality

Currently, accelerated-bridge-cni logs to Stderr and this can't be changed, as result, all logs go to the container runtime log (for example, to the containerd log).

It will be useful to support logging into a file to simplify debugging.

The README does not reflect the CNI config of this plugin. it should be updated so users understand what is an acceptable configuration

we have added a few CVE fixes to accelerated bridge CNI, lets do a release so folks enjoy latest fixes.

perhaps we want to have #57 as well

currently MyNetlink is part of manager.go
it should be in its own file. possibly in a different package (utils ?)

What would you like to be added?

Split plugin configuration and cache only significant one.

What is the use case for this feature / enhancement?

Currently the whole configuration is cached by the plugin, but not whole information used during deletion.

What happened?

Wrong MAC address value returned in Result on CmdAdd when MAC address passed in cni config

What did you expect to happen?

Expected MAC address equal to the one in conf

What are the minimal steps needed to reproduce the bug?

Run cnitool utility with config, which include MAC address field, for ex:

$ export CNI_PATH=/opt/cni/bin
$ export NETCONFPATH=<config file location>
$ ./cnitool add accelerated-bridge-cni /var/run/netns/ns1
{
    "cniVersion": "0.4.0",
    "interfaces": [
        {
            "name": "eth0",
            "mac": "56:0a:69:b3:a6:5b",
            "sandbox": "/var/run/netns/ns1"
        }
    ],
    "ips": [
        {
            "version": "4",
            "interface": 0,
            "address": "10.56.217.2/24",
            "gateway": "10.56.217.1"
        }
    ],
    "routes": [
        {
            "dst": "0.0.0.0/0"
        }
    ],
    "dns": {}
}

Anything else we need to know?

Nope

Component Versions

Please fill in the below table with the version numbers of applicable components used.

Config Files

$ cat /swgwork/dmitrolin/go-src/configs/10-accelerated-bridge.conf
{
  "cniVersion":"0.4.0",
  "name":"accelerated-bridge-cni",
  "type":"accelerated-bridge",
  "deviceID":"0000:82:00.3",
  },
  "runtimeConfig":{
    "mac":"e4:22:33:44:55:66",
  },
  "ipam":{
    "type":"host-local",
    "subnet":"10.56.217.0/24",
    "routes":[{"dst":"0.0.0.0/0"}],
    "gateway": "10.56.217.1"
  }
}

We would like to release a new version of accelerated bridge CNI.

Content:
PR#38 - add support for vfio interface

What would you like to be added?

funlen and gocognit linters disabled because main.go:cmdAdd(), manager.go:ApplyVFConfig() and config.go:LoadConf() produce errors. Need to refactor this part of code.

What is the use case for this feature / enhancement?

Cleaner code

What would you like to be added?

Bump golang version to 1.18 to align with other projects in the org

What is the use case for this feature / enhancement?

following best practices to keep things up 2 date and enjoy latest golang features

currently caching methods are part of config package.

we should move it to its own package

see: https://github.com/Mellanox/rdma-cni/tree/master/pkg/cache

We would like to release a new version of accelerated bridge CNI.

Content:
Add support for MTU #47
Bump go 1.18 and general maintenance #51
Add support for multiple Linux bridges #52

most of npwg projects use github workflow, we should transition to it from travis

If/when/once this project moves to networkplumbingwg org we should push docker images to github container registry
(which avoids the docker image pull limits)

Several features were added since we last released.

• add vlans on uplink
• bump to go 1.19
• implement device info spec 1.1 (add representor-device field)

It would be great to do a release so that users can use a tagged version of accelerated-bridge-cni with latest features.

Do we want additional content to be added for release ?