jxnblk / microicon Goto Github PK

Thank you for this microservice.

Maybe it will be useful to add Cache-Control header to reduce actual request count for users and load for server?

Anything with more than two digits (above 99) is interpreted as a hex color:
https://icon.now.sh/bathasu/160
https://icon.now.sh/plus/fed100/160
https://icon.now.sh/plus/ccc/160

I like that it is simple to reason about and that the order of parameters does not matter. It may be worth documenting. ¯_(ツ)_/¯

This project uses several other projects but doesn't add their license or copyright.

• Material Design Icons are released under the Apache 2 license which requires to include the copyright and the license and to state changes made to the project. IANAL but I wonder if you are allowed to re-license these under MIT. You should probably at least make clear what the license is for which icon set on the website.
• Geomicons and Reline are released under the MIT license (although the license itself is missing in the original repos) which also requires to include their copyright and license.
• Only the Simple Icons don't need anything added because they are released under the CC0 license which doesn't include the same restrictions as the others. But I would think it is good practice to include the license for those as well.

Especially if people are just grabbing URLs for icons, they need to be made aware of under which circumstances they are allowed to use them. I'm not sure if that's legally required, but it would be nice.
I'm sure it is legally required to say at least in the source code what is coming from where and what the license is for each.

https://feathericons.com/

https://icon.now.sh/ is down :(

Sorry if this is covered somewhere, I couldn't find anything in the docs. Is it possible to inherit a color?

Something like
https://icon.now.sh/chevron/16/currentcolor

or should fill='currentColor' be enabled by default?

It would be awesome if there was a <defs> style variant of this to allow for prototyping <symbol> and <use> based icon systems.

For example:

<svg xmlns:xlink="http://www.w3.org/1999/xlink">
<use xlink:href="https://icon.now.sh/defs.svg#chevron-down" fill="red"></use>
</svg>

Perhaps they could be split by libraries to keep the def size down for easier serving & faster loading, like https://icon.now.sh/material.svg#android

After the recent updates, many Geomicons are unavailable due to naming collisions with Material Design icons, which are taking precedence:

The circle element attributes can be converted to path commands on build