jwilberding / bcp Goto Github PK

If receiving file, check to make sure not overwriting, if it will, ask user first.

Test different file sizes and filename lengths.

This project does not seem to contain any licensing information. See "GitHub needs to take open source seriously" for more information as to why this is important, even when posting code on Github.

As I have noticed there is no license used in the project. Shouldn't it be more appropriate to use one in order to protect the project from any unwanted implications ?
And as a free software supporter I suggest using GNU GPL license

Leave up and running so multiple computers can download.

If you turn on the server, that immediately gives anyone on the network the ability to make you overwrite any file on the file system (subject to permissions of the current user). You need to either let the receiver be the one who specifies the filename or strip the path from the filename.

Thanks to latitude:

Try and add support for detecting piped input on the server side:
bcp < filename
because this would allow for things like
cat filename | gzip | bcp
with the receiving end doing
bcp | gunzip > filename

It would be swell if a homebrew formula existed for this simple utility. It's pretty great to use on a network of trusted machines and in labs where many of our users have OSX on their machines.

Tried with a big file over wireless and did not seem to work.

Thanks to jbester:

1. The code assumes both the client and the server have the same endian. This can be issue since a uint32 is used for both the synchronization code (BCP_CODE) and the port. This can easily fixed with htonl/ntohl conversions.

2. it assumes both the client and the server define int to be the same size (may or may not be true based on compiler/processor/OS combinations). If you use stdint definitions, this typically won't be an issue