jvaubourg / puppetlabs-nginxpack Goto Github PK

Hi,

With logrotate enabled, I've this error messages /var/log/nginx/<vhost>/access.log is owned by www-data. any reasons for that?

/etc/cron.daily/logrotate:
error: skipping "/var/log/nginx/monitoring/access.log" because parent directory has insecure permissions (It's world writable or writable by group which is not "root") Set "su" directive in config file to tell logrotate which user/group should be used for rotation.
error: skipping "/var/log/nginx/monitoring/error.log" because parent directory has insecure permissions (It's world writable or writable by group which is not "root") Set "su" directive in config file to tell logrotate which user/group should be used for rotation.

The vhost log directory is owned by root (and only root can write there):

# From Nginxpack::Vhost::Basic
file { "/var/log/nginx/${name}/":
    ensure => directory,
    mode   => '0770',
    owner  => 'root',
    group  => 'root',
}

However the log file should be writeable by www-data:

the user whose credentials are used by worker processes should have permissions to create files in a directory with such logs;

The result is a bunch of errors such as:

2017/09/06 06:32:23 [emerg] 6964#0: open() "/var/log/nginx/example/access.log" failed (13: Permission denied)

See issue #7 however.

Maybe we need in the logrotate snippet:

su www-data adm

At the moment when using use_php after rebooting the server php-fpm service doesn't start automatically at boot time.

In my opinion nginx should be reloaded when modifying value of $add_config_source or $add_config_content in the manifest.

Changing :

line => inline_template('post_max_size = <%= \ (@upload_max_files.to_i * @upload_max_filesize[0..-2].to_i).to_s\ + @upload_max_filesize[-1]%>'),

to

line => inline_template('post_max_size = <%= \ (@upload_max_files.to_i * @upload_max_filesize[0..-2].to_i).to_s\ + @upload_max_filesize[-1].to_s %>'),

seems to fix it.