Git Product home page Git Product logo

Comments (4)

espen avatar espen commented on September 22, 2024 1

I'm using AUTOSCALER_APP and AUTOSCALER_ACCESS_TOKEN.

I don't think the variable length is an issue. If Heroku has a max length it's quite long (considering it's a name). I think it's more important to show autoscaler in the name than Heroku though. So my vote would either be AUTOSCALER_HEROKU_APP or if a shorter version is preferred then AUTOSCALER_APP. But it's not really that important, the only key thing is to not have HEROKU_* for apps on the new stack.

insert joke about two difficult things in computer science

from autoscaler.

JustinLove avatar JustinLove commented on September 22, 2024 1

0.14 adds AUTOSCALER_ prefix, old form supported with warning.

from autoscaler.

JustinLove avatar JustinLove commented on September 22, 2024

Any preference for

AS_HEROKU_APP
AS_HEROKU_ACCESS_TOKEN

vs

AUTOSCALER_HEROKU_APP
AUTOSCALER_HEROKU_ACCESS_TOKEN

Last being more explicit, but a bit long.

from autoscaler.

JustinLove avatar JustinLove commented on September 22, 2024

Secondly, there might be a major release at some point to remove old api (#65) Would it ever make sense to remove the old variables a fallback option?

from autoscaler.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.