Git Product home page Git Product logo

Comments (15)

mtthwhggns avatar mtthwhggns commented on June 19, 2024

You possibly know this @siong1987 , but for reference for anyone who finds this and is looking for a solution;

If you install the gem directly from the GitHub source, it loads the most recent version here, which is compatible with sidekiq 3, and seems to work fine.

Instead of

gem 'autoscaler'

Just use

gem 'autoscaler', :git => 'git://github.com/JustinLove/autoscaler.git'

from autoscaler.

siong1987 avatar siong1987 commented on June 19, 2024

@MatthewEHiggins that's exactly what i am doing now. but since sidekiq 3.0 has been out for a while, i think that it's time to release a new version. :)

from autoscaler.

Ganasist avatar Ganasist commented on June 19, 2024

So does it work with:
gem 'autoscaler', :git => 'git://github.com/JustinLove/autoscaler.git'

I just tried to set it up and it did not seem to affect worker number. Even after I triggered a job and waited a few minutes the workers seemed to be running as usual.

Rails 4.2
sidekiq 3.2.4

from autoscaler.

mtthwhggns avatar mtthwhggns commented on June 19, 2024

It seemed to work fine for me when I did it that way.

Do you have any scheduled jobs at all? As they appear to make workers stay running in my set up?

from autoscaler.

Ganasist avatar Ganasist commented on June 19, 2024

No scheduled jobs. I thought maybe having sidekiq/web enabled was the problem, so I disabled it and no go.... BUT I should be clear that I wasn't using:
gem 'autoscaler', :git => 'git://github.com/JustinLove/autoscaler.git'

I was using:
gem 'autoscaler'

I figured maybe Heroku blocked Autoscaler (is that possible?) because they offer a paid add-on that does something similar now:
https://addons.heroku.com/adept-scale

from autoscaler.

mtthwhggns avatar mtthwhggns commented on June 19, 2024

I see!

I think it's very unlikely Heroku has blocked it, and if they did, it would probably give an error message to let you know that!

If you're using SideKiq 3, how were you able to install the gem without loading the GitHub version directly? When I tried that, it wouldn't bundle/build at all? Have you double-checked the other set-up steps from readme?

In my setup (same app in staging/production) the staging app correctly scales right down to zero (using, but my production app almost always has something scheduled, so is always running at least one dyno, even when they are scheduled for hours/days in the future.

from autoscaler.

Ganasist avatar Ganasist commented on June 19, 2024

Ok I just tried the exact same thing with the GitHub version and it works, great! I'm using it in production, since in Staging I have Sidekiq running within the Unicorn process (to save costs and run on one dyno).

Its unfortunate that scheduled jobs 'break' this functionality. I'll have to keep that in mind in the future!

Thanks for your help!

from autoscaler.

Ganasist avatar Ganasist commented on June 19, 2024

I spoke too soon. The worker spun down, but when I triggered a new background task it didn't spin back up again! Oh well, almost got it. Luckily it wasn't critical that I got this working, it would have been icing on the cake...

from autoscaler.

claudiob avatar claudiob commented on June 19, 2024

@JustinLove great job with this project!

I agree that it would be nice to have a new version of the gem on Rubygems.org

What's your opinion on that?

from autoscaler.

devill avatar devill commented on June 19, 2024

+1 for new release! It looks a bit like a hack to add the github repo into the Gemfile

from autoscaler.

tmaier avatar tmaier commented on June 19, 2024

@JustinLove: Sidekiq 3 support seems not to be high on your priority list, but it would be really great if you could cut out a new gem for us :)

from autoscaler.

JustinLove avatar JustinLove commented on June 19, 2024

CC @bkudria #32 ?

from autoscaler.

warmwaffles avatar warmwaffles commented on June 19, 2024

Any news on cutting a new release to support sidekiq 3?

from autoscaler.

JustinLove avatar JustinLove commented on June 19, 2024

Master is caught up with pull requests and issues I intend to implement. I still don't have an application for this and am relying on unit tests. Anybody with an application care to smoke test it?

from autoscaler.

claudiob avatar claudiob commented on June 19, 2024

I just tried in production (on Heroku) and it works. If you cut a gem at this version, I'm going to point at it.

Thanks again for your work.

from autoscaler.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.