Git Product home page Git Product logo

reservationapp's Introduction

ReservationApp

To run the app just clone the repo to a new project in intellij idea IDE. Then find a file called pom.xml. Right click this file and select maven -> reload project. Intellij will probably notify you that a maven file is located and it will ask you if you want to load it. The app needs a database i used postgresql. To add a database just configure your application.properties file so it looks like the application.properties.example file that i provided in this repo.

reservationapp's People

Contributors

jurck222 avatar

Watchers

 avatar

reservationapp's Issues

Review

Všeč mi je

  • da ste uporabili zadnjo verzijo Spring Boot med razvojem
  • da ste smiselno razbili aplikacijo po "tier"ih: controller, service, model, views itd
  • da preverjate, ali je termin prost
  • da ste uporabili ORM za povezavo z bazo (spring-boot-starter-data-jpa oz. hibernate)

Predlagani popravki

  • da se doda .gitignore s tipičnimo vnosi za Javo (npr., da target ni shranjen v git)
  • da se počisti neuporabljene importe (Intellij npr. ponuja optimize imports)
  • da se koda konsistentno formatira (npr. presledki pred oklepaji, catch), prazne vrstice (npr. da ni pod @transactional)
  • v templates je 2x vključen bootstrap, tudi različne verzije. Tole bi bilo lepše narediti kot nek fragment (več načinov), da se ne ponavlja
  • čeprav so v HTML formi required polja, je zelo dobro, da se uporabi tudi na backendu kakšna validacija (v primeru, da bi kdo poskušal pisati v DB mimo HTML forme). Spring boot npr. ponuja validation api, anotacije npr. @NotNull na properties modela Reservation.

Vprašanja

  • Kako bi dosegli, da lahko poganjate isto aplikacijo v več okoljih (npr. da baze ne bi napolnili s testnimi podatki v PROD okolju)?
  • V primeru, da ne bi imeli server side renderinga s Thymeleaf, ampak bi imeli SPA frontend (tu npr. v glavnem uporabljamo Angular), kako bi potem preoblikovali aplikacijo?
  • uporabljena je kar visoka verzija Jave, ne pa zadnja. Kje v vaši kodi bi lahko uporabili var keyword, kar podpira Java 17+?

Arnes

Pozdravjeni,

Hvala, da ste se odzvali in potrudili z nalogo.

Bomo pregledali rešitev. V primeru, da bi imeli kaj vprašanj, predlogov itd. glede same naloge, predlagam, da kar tu preko zahtevkov komuniciramo.
Kako se pa je vam zdela naloga?

Lp, Klemen

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.