Git Product home page Git Product logo

ticket-system's Introduction

  • 👋 Hi, I’m @junyang-chin
  • 👀 I’m interested in Web development
  • 🌱 I’m currently working on writing maintainable code with design patterns
  • 💞️ I’m looking to collaborate on any open source project preferably in the context of Malaysia
  • 📫 How to reach me [email protected]

I write Object Oriented PHP most of the time but that doesn't limit me to exploring new languages and programming paradigms.

Jun's GitHub stats Top Langs

ticket-system's People

Contributors

junyang-chin avatar

Watchers

avatar

ticket-system's Issues

Code Review 14/10/2022 - master branch

Concept Application

  • Migration
  • Seeder
  • Route
  • Blade
  • Model
  • Controller
  • Request Validation
  • Authentication Sanctum
  • Role & Permission
  • Policy Authorization
  • Middleware
  • API Resource
  • DB Query / Eloquent ORM
  • Collection Methods
  • Notifications
  • Observer
  • Factory
  • Job & Queue
  • Relationships
  • Helpers
  • Accessors / Mutators/ Scope
  • HTTP Client
  • Event & Listeners
  • Command
  • File Storage
  • Localizing, Transalation
  • Cache
  • Reflection

Functionality Application

  • User auth
  • User roles
  • Ticket Information
  • Title
  • Description
  • Priority
  • Category
  • Status

Best Practice Application

  • Naming convention
  • Folder Structure
  • Documentation
  • .env.example documentation
  • ReadMe Update
  • API Insomnia documentation
  • Method descriptions
  • TDD Approach
  • Feature Test Coverage
  • Unit Tests Coverage
  • SOLID
  • PSR

Comments

  1. Hint of advance usage of relationship method developers() in Ticket model or assignments() in User model
  2. Some documentation exist for other developers
  3. Unused methods are not removed or clean up such as edit() in AssignmentController. Debug code need to be removed from master code.
  4. There is usage of service class AssignmentService
  5. Redundancy in query, unused Reflection concept. Model are retrieved twice. Eg, inside show() in UserController
  6. For long list of data, pagination can be use to split response into multiple page
  7. Unhandled ModelNotFoundException should return json response.
  8. Invalid abort() after response. Eg: in update() method in TicketController. Anything after return will not be executed.
  9. Seeding multiple rows would be better using insert array which use a single query transaction.

Review Date: 14/10/2022

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.