jumaallan / dev-fest-2019 Goto Github PK

Is your feature request related to a problem? Please describe.
Managing dependencies and versions in the current set up is difficult

Describe the solution you'd like
Instead of using the shared_dependencies.gradle file, dependencies can be migrated to the buildSrc folder and shared across modules.

Additional context
AndroidX libraries use buildSrc to manage dependencies.

Add logic on Weather Module to fetch and display weather details

Is your feature request related to a problem? Please describe.
We can add Dagger 2 to one module to show how other developers how you can use it especially in a multi module application.

Describe the solution you'd like
Implement Dagger 2 in one module.

Additional context
Dagger Basics Tutorial
Dagger Codelab
Benchmarks Comparing the different DI solutions available

Code readability.
As the code base grows, we need to make sure its properly documented so as to make it easy for users to understand what the code does, args needs, what it returns and why

Solution
Make sure all methods are properly commented, to make documentation easy.

Additional context
We might need to have a CI which performs this check, not sure. Open to ideas

Add Logic to fetch movies from Rick and Morty API