Git Product home page Git Product logo

Comments (2)

devmotion avatar devmotion commented on July 27, 2024 2

AFAICT this issue (and the suggested fix) are already discussed in JuliaArrays/StaticArrays.jl#1218.

from distributions.jl.

andreasnoack avatar andreasnoack commented on July 27, 2024

I believe this issue belongs in StaticArrays. The inverse of the Cholesky here isn't symmetric

julia> issymmetric(MvNormal(μ, Σ).Σ.mat)
true

julia> issymmetric(inv(MvNormal(μ, Σ).Σ.chol))
false

This is probably because it's computed as two solves in https://github.com/JuliaArrays/StaticArrays.jl/blob/5913f330ac4834ef1521bc7faa626a0be1d6bb7a/src/cholesky.jl#L72C1-L74. Two solves is probably also more expensive than needed. A single solve followed by a symmetric rank-k update should be more efficient and ensure symmetry.

from distributions.jl.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.