juliasmoothoptimizers / bundleadjustmentmodels.jl Goto Github PK

• add unit tests to verify that residual evaluation does not allocate
• add unit tests to verify that jac_residual_structure does not allocate
• make jac_residual non allocating
• add unit tests to verify that jac_residual does not allocate

CirrusCI can run CI for PRs opened by the code format bot.

The tutorial from JSOTutorials ran and returned an error: https://juliasmoothoptimizers.github.io/JSOTutorials.jl/introduction-to-bundleadjustmentmodels/

It is the same as the tutorial here, so maybe some dependency was updated and broke it?

Add thanks to Célestine Angla for her initial work on this matter as a master thesis.

The current version calls jac_structure!() each time.

Since it doesn't have second-order information nor Jacobian-vector products, I am not sure how to solve this model. The tutorial should have something.

Like here: https://github.com/JuliaSmoothOptimizers/Krylov.jl/blob/main/CITATION.bib

Some docstrings are missing a full stop. Types and function names should appear in code blocks.

https://citation-file-format.github.io/cff-initializer-javascript/#/start

Here:

Otherwise it gets set to the maximum n * (n + 1) / 2.

In the current version of the code, there is a increment of evaluations on jac_coord! and jac_structure! which needs to be clarified.

Thanks @AntoninKns for this great repo!

I was checking the BundleAdjustmentModel, which follows the NLSModel API, and I have a couple of comments:

• I think the jacobian of the residual should be described by jac_structure_residual! and jac_coord_residual! and not jac_structure! L.159 and jac_coord! L.196.
• Adding the functions jprod_residual!, and jtprod_residual! would be very useful.
• I might have missed it, but it could be useful to add somewhere in the documentation that the BundleAdjustmentModel doesn't return any second-order information on the residual.
• Finally, I believe the docstring of BundleAdjustmentModel L.5 might be misleading since the model is a nonlinear least-square optimization problem.

The instructions in README.md are no longer accurate. They should be modified as in the documentation.

This issue is used to trigger TagBot; feel free to unsubscribe.

If you haven't already, you should update your TagBot.yml to include issue comment triggers.
Please see this post on Discourse for instructions and more details.

If you'd like for me to do this for you, comment TagBot fix on this issue.
I'll open a PR within a few hours, please be patient!

I think there's something wrong with some of the artifacts of this package:

• the tree hash doesn't seem to match: JuliaRegistries/RegistryCI.jl#481
• there appears a .sha256 file in the artifact store, e.g., problem-49-7776-pre.txt.bz2.sha256

Both are a problem because the artifact store is supposed to be content-addressable, so the tree hash should match.