juliaibpm / gridpotentialflow.jl Goto Github PK

@JuliaRegistrator register

This issue is used to trigger TagBot; feel free to unsubscribe.

If you haven't already, you should update your TagBot.yml to include issue comment triggers.
Please see this post on Discourse for instructions and more details.

If you'd like for me to do this for you, comment TagBot fix on this issue.
I'll open a PR within a few hours, please be patient!

Rotational motion of the bodies cannot be modeled at this moment. For this, the type ModelParameters and internal method _computeψboundaryconditions! have to be extended.

Furthermore, the method computeimpulse does not return the rotational component of the impulse and the matrix returned by computeaddedmassmatrix does not include entries for rotational motion. The formulas are in the paper but they still need to be implemented and tests need to be provided.

The methods and types in this package should be rewritten to model multiple bodies that satisfy edge conditions. For this to work, it might be necessary to create a PotentialFlowBody type that encapsulates Ub, Γb, and any regularized edges belonging to that body.