juhalehtonen / ex_uptimerobot Goto Github PK

The editMWindow API method is missing.

The following are not present:

• POST newAlertContact
• POST editAlertContact
• POST deleteAlertContact

The README currently mentions how not all features of the Uptime Robot API are supported. This should be corrected once all API method wrappers are added.

All PSP-related API methods are currently missing:

• getPSPs
• newPSP
• editPSP
• deletePSP

Currently the tests are calling the real API, which can result in unexpected behaviour and inconsistent results (timeouts at any point in time can make the build fail).

This could be achieved with something like https://github.com/jjh42/mock

Currently all function names are more or less identical to how the official API names its methods.

However, since we are already separating different types of API calls to their own modules, it would make sense to clean up the function names and let the distinctively named modules to handle the separation.

For example, there's no real need for the function to get maintenance windows to be called ExUptimerobot.MaintenanceWindow.get_maintenance_windows() when it could just be ExUptimerobot.MaintenanceWindow.get(). The same applies for everything else, such as how ExUptimerobot.Monitor.new_monitor() could just as well be ExUptimerobot.Monitor.new().

I'm not planning on introducing this change right away, but rather would like to collect some data and thoughts about the change first. In case anyone has any further thoughts on this, please do share.

PSP support was added recently, but tests for them are still missing.

The ExUnit tests currently in place use the Mock library, so the new tests should follow suit.