jubianchi / jsimple Goto Github PK
View Code? Open in Web Editor NEWa JS dependency injection/service locator highly inspired from Pimple for PHP
Home Page: http://jubianchi.github.io/jsimple/
License: MIT License
a JS dependency injection/service locator highly inspired from Pimple for PHP
Home Page: http://jubianchi.github.io/jsimple/
License: MIT License
Hey! Here is a little feedback:
// Shared service
container.share("foo", () => {
return /* object */;
});
// New service every time
container.factory("foo", (c) => {
return /* object */;
});
// Register function
container.share("foo", container.protect(/* function */));
// Parameter
container.define("foo", /* anything */);
// Extend
container.extend("foo", (previous, c) => {
return /* anything */;
});
Wouldn't it be possible to simplify the API? It's a lot of different use cases and to learn/remember them I think it might be challenging. Especially since there might not be a difference between registering a function and registering a parameter for example? (both are simply stored and returned)
So how about using define
to register functions? That would leave share
, factory
, define
and extend
.
Or you can go the other way and keep container.proctect
and merge share
and define
together?
// Shared service
container.share("foo", () => {
return /* object */;
});
// New service every time
container.factory("foo", (c) => {
return /* object */;
});
// Register function
container.share("foo", container.protect(/* function */));
// Parameter
container.share("foo", /* anything */);
// Extend
container.extend("foo", (previous, c) => {
return /* anything */;
});
Also I'm not sure of how much useful tags are? They do complicate the API where one could simply use extend
? I.e. it seems you are reusing both Symfony's and Silex's solution to solve the same problem (tags and "extend").
Before:
container.share("app.static", container.protect(express.static("public")), ["middleware"]);
container.share("app.static", container.protect(express.static("files")), ["middleware"]);
container.extend("app", (app, c) => {
c.tagged("middleware").forEach(middleware => app.use(c.get(middleware)));
return app;
});
After:
// Module 1
container.extend("app", (app) => {
app.use(express.static("public"));
return app;
});
// Module 2
container.extend("app", (app) => {
app.use(express.static("files"));
return app;
});
A declarative, efficient, and flexible JavaScript library for building user interfaces.
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
The Web framework for perfectionists with deadlines.
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. ๐๐๐
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
We are working to build community through open source technology. NB: members must have two-factor auth.
Open source projects and samples from Microsoft.
Google โค๏ธ Open Source for everyone.
Alibaba Open Source for everyone
Data-Driven Documents codes.
China tencent open source team.