Hi 👋, I'm Juan

Fullstack developer from Argentina

Connect with me:

Languages and Tools:

vite-plugin-make-offline's People

Contributors

Stargazers

Watchers

vite-plugin-make-offline's Issues

Vite build options are overridden

I have my vite build options set, and was using the markOffline() plugin, but the build options were being overwritten, and I didn't understand why, until I looked at the plug-in source code.

For example, I had this

import { defineConfig, loadEnv } from 'vite'
import react from '@vitejs/plugin-react-swc'
import { makeOffline } from "vite-plugin-make-offline";

// https://vitejs.dev/config/
export default defineConfig(({ mode }) => {
    const env = loadEnv(mode, process.cwd(), '');
    console.log("vite mode....: ...  yep >>> ", mode)
    // other code
    return {
        plugins: [
            react(),
            makeOffline(),
        ],
        base: './',
        build: {
            outDir: "build",
        },
    }
})

The and running npm run build did not generate the build directory. I managed to get it working using this config

// Source from https://github.com/JuanQP/vite-plugin-make-offline without
// overriding all the build options.
import { UserConfig } from "vite";

export function makeOffline() {

  return {
    name: 'iife' as const,
    apply: 'build' as const,
    enforce: 'post' as const,

    config: (config: UserConfig) => {
      config.base = "./"
      config.build = {
        ...config.build,
        rollupOptions: {
          ...config.build?.rollupOptions,
          output: {
            ...config.build?.rollupOptions?.output,
            format: "iife",
          }
        }
      }
    },

    transformIndexHtml(html: string) {
      return html.replace(' type="module" crossorigin ', ' defer ');
    },
  }
}