jtpereyda / ezoutlet Goto Github PK

On Windows, when I added the HTTP_PROXY environment variable, ezoutlet started using the proxy even for 192.168.. addresses, meaning it stopped working.

One potential solution is given here: http://www.decalage.info/en/python/urllib2noproxy

proxy_handler = urllib2.ProxyHandler({})
opener = urllib2.build_opener(proxy_handler)
urllib2.install_opener(opener)
return urllib2.urlopen(url, timeout=self._timeout).read()

Edit: Post originally mentioned HTTPS_PROXY, but HTTP_PROXY is the variable that matters.

This page specifies a total of 8 exceptions. We should evaluate and catch them more thoroughly than we do.

Current usage is:

ezoutlet 192.168.1.12  # -t 10

This works great for resetting, but leaves the app hard to extend. Consider using an explicit reset command:

ezoutlet reset 192.168.1.12  # -t 10  

This will make it very easy to add commands like on and off in the future.

Add step python setup.py clean --all. Maybe there's more.

Update the classifiers in setup.py. They currently say the package is in Beta, which is no longer true. It should be in release.

The unit tests pass on my machine, but fail on the continuous integration server. The reason isn't clear, but it happened at build 16 https://travis-ci.org/jtpereyda/ezoutlet/builds/107887962.

This was several changes ago, which is what I get for not using PRs and just committing straight to master.

This is best put in a user's global gitignore.

How can this app supply a password to the ezoutlet3 device?

It would be nice to make this package a hybrid.

The usage in README reflects the old version, without the subcommand. Fix.