jt3k / chat-linker Goto Github PK

From XMPP room:

<tg> <@undefined> как реализовать работу 9 работ практических на одной странцы ?

At the same time in Telegram I can see the name of the man who wrote that, but he somehow has no nickname:

Use tips from this list https://github.com/matiassingers/awesome-readme

Since there is no easy way to transfer stickers from telegram to jabber, I suggest sending emoji bound to this sticker.

example:
In jabber-side sticker can look like here

<@vasya> sends sticker: 🍷🍻🎶

$ npm run prod
npm info it worked if it ends with ok
npm info using [email protected]
npm info using [email protected]
npm info lifecycle [email protected]~preprod: [email protected]
npm info lifecycle [email protected]~prod: [email protected]

> [email protected] prod /usr/app/src
> NODE_ENV=prod app.js

sh: 1: app.js: not found

It seems like you're missing node in your script definition: "prod": "NODE_ENV=prod app.js" should be "prod": "NODE_ENV=prod node app.js".

for example with generator-nm

XMPP supports message editing (see XEP-0308) just as Telegram do (see #18).

This is a dual issue for #18: we need to get some insight on bots' ability to edit their own messages in Telegram and implement proper support for edited XMPP messages in the bot. So, when a user edits his/her message in XMPP, the edit should be transparently translated to Telegram.

Currently I doubt that Telegram bots can edit their messages; I'll ask the experts.

When any XMPP user posts a message like that:

<user> $`

It gets wrongly translated to Telegram, because it's a meta-character for String.prototype.replace.

Possible solution: resend to xmpp fixed message with citation.

type coverage of src/bots/jabber/client.js file is only 55%.

Now in telegram messages look like this

I want them to look like this

Consider this scenario:

1. XMPP gets implicitly disconnected, but the client is still not aware of it.
2. Bot receives a Telegram message.
3. Bot tries to send it to XMPP and realizes it's disconnected. XMPP throws an error.
4. Bot reconnects to XMPP and everything is alright, except that the message it tried to send at p. 3 is now lost.

Bot should buffer the message if an error has been occured on send and resend the message after the reconnect.

maybe it related to #44

• summary
• funny image
• installation
  • config info
• usage
• contribution info
  • husky

  do not see the reply-message on the jabber side, (at the same time the smiley itself is displayed)

in linking mechanism in configuration

the problem

stop forwarding the message to jabber after rename the telegram-group

Currently Telegram messages aren't very compact: they look like

username
Message body.

I suggest to add an option to change the format to more compact, such as

<username> Message body.

Sometimes bot is disconnected from XMPP, and it restores the connection only after any message to Telegram. I suspect that something's wrong with client timeouts; please make it configurable.

Some guys are complains about /me on XMPP side. Probably it'll be better to remove that (and send the messages as is, without and prefixes).

Current implementation uses single account to send all messages.
I propose changing this behaviour by using multiple connections into a single conference in XMPP with resources matching telegram user names. (e.g. [email protected]/username)

So if you have a chat of user1, user2, user3 you should join [email protected] three times with nicknames (and from resources) of /user1, /user2, /user3 and send messages from appropriate resource.

On a nick collision add some prefix or suffix.

Later this may be reworked to create a service when the bot can link two chatroom of different networks by a user command.

For sending images to xmpp chat.

https://github.com/jt3k/chat-linker/blob/master/README.md states that

demo XMPP-side: [email protected] (RU)

but it doesn't seem to be present there.

with info about this repo and linked networks

const chat = config[process.env.NODE_ENV];

ain't good, we should make getting of config external passing it as args to entry point, bots should know anything about Node or any other env they're running on

It would be great if the chat-linker could support the plug-ins.

This would make it easier to add functionality, for example anti-spam or anti-obscene-swearing.

At the first stage, I would like to see a synchronous or asynchronous middleware.
For example, as it is done in axios interceptors or babel-plugin

plugin example:

module.exports = ({
 interceptors: [
  {
   from: 'telegram', // or from: '*'
   to: 'xmpp',
   interceptor({ network, name, message, room }) {
    // message processing here
    return { network, name, message, room }
   }
  }
 ]
})

support linking for more than one chat room

python_jabber <--> python_telegram
js_jabber <--> js_telegram
...

if you forward a message with a sticker then it is not visible on the jabber side

in console i see

  TypeError: Cannot read property 'replace' of undefined
      at ForwardedMessage.toString (/Users/jt3k/tmp/chat-linker/bots/telegram/client.js:74:29)
      at prepareMessage (/Users/jt3k/tmp/chat-linker/bots/telegram/client.js:123:33)
      at prepareEmittingMessageDetails (/Users/jt3k/tmp/chat-linker/bots/telegram/client.js:135:15)
      at client.on (/Users/jt3k/tmp/chat-linker/bots/telegram/client.js:149:15)
      at Promise.resolve.then (/Users/jt3k/tmp/chat-linker/node_modules/telegraf/lib/core/composer.js:81:56)
      at <anonymous>
      at process._tickCallback (internal/process/next_tick.js:188:7)

Currently, if someone quotes the big message in Telegram, the whole message gets copied into XMPP room.

Probably we should add a configurable limit for quoting (line count, character count)? Cut the quotes that exceeds the configured limit with ellipsis.

Message example:

Click me

On jabber it looks like this:

Click me

• throw exception if app-config.json is not exist
• rename app-config.json to sample-config.json
• add app-config.json to .gitignore
• maybe someday make a script to create the configs

For example, I'm hosting chat-linker on my own server and I don't need any prevent-sleep.js functionality. It should be possible to completely disable that module through the configuration.

Windows users are reporting that they are unable to execute npm run prod because prod script if defined as NODE_ENV=prod node app.js in our package.json.

We need to use cross-env to set the environment variable uniformly across the platforms.

• tests
  • xo
  • units
• deploy

Consider the following situation: three Telegram users post some messages in one second, e.g.

(TELEGRAM SIDE)
[12:34:56] <@telegram1> msg1
[12:34:56] <@telegram2> msg2
[12:34:56] <@telegram3> msg3

These messages should be translated by bot without any problems:

(JABBER SIDE, EXPECTED)
[12:34:57] <tg> <@telegram1> msg1
[12:34:57] <tg> <@telegram2> msg2
[12:34:57] <tg> <@telegram3> msg3

But actually some messages will definitely be lost:

(JABBER SIDE, ACTUAL)
[12:34:57] <tg> <@telegram1> msg1
[12:34:57] <tg> <@telegram3> msg3

this leads to the fact that the bot must be restarted by hands every few days.

Try to post image to Telegram. It won't cause any measure effect on XMPP room. That's inappropriate.

At least show something like [Image posted], but better repost the image to some server (probably keep it on your own Heroku instance) and post the link to XMPP.

in telegram forwarded message looks like this:

now in xmpp we see:

8:35 @jt3k проветка
8:35 +tg <@iyntx> прошла успешно
8:35 +tg <@iyntx> >> <robotron3000bot> jt3k
>> проветка

I would like, on the xmpp side, to see a more consistent visual look:

8:35 +tg <@iyntx> прошла успешно
>> Forwarded from [email protected]<@robotron3000bot>
>> <jt3k> проветка

or like this:

8:35 +tg <@iyntx> прошла успешно
8:35 +tg  >> Forwarded from [email protected]<@robotron3000bot>
>> <jt3k> проветка

8:35 and +tg is only displayed in the xmpp client

• text
• forwarded message
• reply
• photo [partially]
• document [partially]
• sticker [partially]
• audio
• video
• video_note
• voice
• contact
• location
• venue
• game
• new_chat_participant
• left_chat_participant
• new_chat_photo
• delete_chat_photo (service message)
• new_chat_title
• invoice
• successful_payment (service message)