jszwec / s3fs Goto Github PK

I noticed you use functional options (which is great), but way they are currently implemented is not perfectly concurrent safe.

Here is the option type:

// Option is a function that provides optional features to S3FS.
type Option func(*S3FS)

The problem with this signature is that you can use options after initialization to modify the state of S3FS:

WithReadSeeker(New(...))

You can avoid that by introducing a private option struct:

// Option is a function that provides optional features to S3FS.
type Option func(*s3FSoptions)

An even better solution is making the Option type an interface:

// Option is a function that provides optional features to S3FS.
type Option interface{
    apply(*S3FS)
}

Using any of the above methods callers won't be able to modify internal state after initialization.

Any plan to upgrade to v2? v1 has some vulnerabilities.

I believe I've identified a bug that causes Stat() to fail in certain circumstances. Given two objects, a/b.txt and a.txt, a call to fs.Stat(fsys, "a") will fail: open a: file does not exist. I believe this is because the MaxKeys budget (of 1) in the call to ListObjects is used-up by a.txt in the response Contents (link).

I'll submit a failing test in a PR