jstockwin / film-night Goto Github PK

Going to used in Coombs' Method.

It shows the score that the borda count assigns to it when it is eliminated. When a candidate is removed the borda count now has less candidates so the score for coming first is reduced etc. Hence the scores are often decreasing although at each step a higher score is better. In Nanson candidates below the average are eliminated so having scores which are not monotonic occurs quite frequently. This could be fixed by specifying the top score in the borda count but it doesn't quite fit with the idea of removing a candidate and running the count as if the candidate was never there.

Should probably also only continue to send voting emails etc if the user has said they're attending film night.

On android the favicon is not visible as it is the same colour as the theme. Can we use a white favicon if the user is on an android phone? Or should we just change the theme colour?

At the moment submitting the same film multiple times would fill up the strings for who proposed the film and who wants to veto it.

• Move the JS into separate files that are either linked or included.
• Split the styles.

Check the colours used and create a global palette. Is the purple used for the veto in voting the same as the purple used in node colours?

It needs entirely redoing so that it can persist across page loads.

This should be a simple case of comma separating the end points.

• May need to make the end point field in the SQL DB longer? (It's currently 255)
• Users should be able to remove each individual browser from getting notifications. This should simply be removing the correct entry from the list. Should also have an "unregister all" button.
• What happens if e.g. the user gets a new pc/phone. They'll end up with unwanted end points. Is this an issue? Presumably nothing will break, but could eventually cause problems?

Votes of the wrong form can cause the JavaScript to get stuck in an infinite loop and crash.
e.g.

• AV (and presumably the other runoff voting methods) loop forever if the only films to remove are not in the listOfCandidates.
• Borda count can't cope if a film isn't in a vote.

We should sanitise the votes either on the server, in the Javascript voting methods or both.

Fortunately the members are too nice and/or too incompetent to ruin film night by submitting votes of the wrong form. Unfortunately they have almost managed to ruin film night by submitting terrible films.

Like this one:

http://nathanielw.github.io/nz-flag-graph/

Support for the w3c Push API could be cool for notifying us of roll-call/start of voting/results availability. Currently has basic support in Chrome 42 and more complete support in Firefox 44 https://developer.mozilla.org/en/docs/Web/API/Push_API

It is used in each step of AV so it will be implemented as an function anyway.

Will probably just change the text of the "Submit" button. If things go well, it will be "Submit" -> "Submitting" -> "Submitted", else it will be "Submit" -> "Submitting" -> "Error"

9f5795f

• IDs should be lowercase.
• Shouldn't override the padding
• Only one of the buttons gets updated so the reveal is ruined. This also causes the problem which was "fixed" by overriding the padding.

We need a custom 404 page. This might need to be done on jstockwin.github.io, as filmnight is hosted as a folder within that site?

Can we make custom forbidden pages too? (https://jakestockwin.co.uk/filmnight/admin/execute.php)

Possibly use a search input type for the name as that you get a nice search icon on the keyboard. I would go for tel over search for the year to force numbers.

Titanic II plot contains double quotes. Other plots contain single quotes. Will need to start URLEncoding/Decoding plots.

In particular these should toggle the value that they represent and not just pass the click through.

When you click log out, you are logged out. However, google automatically signs you straight back in.