jspahrsummers / grocerylist Goto Github PK

This is such a cool project. Just what I've always wanted for dealing with my lists.

For some reason, my Simulator isn't updating the main listing when I add a new item to the list. This is what I saw after I created the item "Wheat Bread":

Pulling to update didn't help. Is this lag on GitHub's side?

Trying to use a newly-created repository (no content whatsoever) will fail with HTTP error code 409. At least one file must exist first.

Make them more consistent and less ambiguous.

Xcode 5.1 (5B130a)

$ clang --version
Apple LLVM version 5.1 (clang-503.0.38) (based on LLVM 3.4svn)
Target: x86_64-apple-darwin13.1.0
Thread model: posix

Deprecated compiler flags in .xcconfigs

clang: error: argument '-fcatch-undefined-behavior' is deprecated, use '-fsanitize=undefined-trap -fsanitize-undefined-trap-on-error' instead

In these files:

• ./External/ReactiveCocoaLayout/External/Archimedes/Configuration/Base/Configurations/Debug.xcconfig
• ./External/OctoKit/External/ReactiveCocoa/external/xcconfigs/Base/Configurations/Debug.xcconfig
• ./External/OctoKit/External/Mantle/Configuration/Base/Configurations/Debug.xcconfig
• ./External/ReactiveCocoaLayout/External/ReactiveCocoa/external/xcconfigs/Base/Configurations/Debug.xcconfig
• ./External/ReactiveViewModel/External/ReactiveCocoa/external/xcconfigs/Base/Configurations/Debug.xcconfig

Unused consts in Mantle when compiling with DEBUG

./External/OctoKit/External/Mantle/Mantle/MTLManagedObjectAdapter.m:39:24: error: unused variable 'MTLManagedObjectAdapterErrorExceptionThrown' [-Werror,-Wunused-const-variable]`
./External/OctoKit/External/Mantle/Mantle/MTLJSONAdapter.m:19:24: error: unused variable 'MTLJSONAdapterErrorExceptionThrown' [-Werror,-Wunused-const-variable]`

I added #ifdef DEBUG to work around it quick’n’dirty

Floating point conversion error

• ./GroceryList/GCYViewController.m:55:64: error: implicit conversion loses floating-point precision: 'double' to 'CGFloat' (aka 'float') [-Werror,-Wconversion]

Configuration file not being found

The README says to put the file in the Configuration directory of the project, but the ./Configuration/GroceryList.xcconfig includes it differently. Should be

#include "Configuration/UserSettings.xcconfig"

It ain't pretty, but it might help convey what the app does and how it flows (without doing all the nonsense that it requires to build).

As soon as the user starts typing, offer to complete the item name with previous entries (ordered by frequency or recency).

Allow a quantity to be entered (and edited) per item.

I'm receiving the following error whenever I add/edit items within a list.

Error Domain=OCTClientErrorDomain Code=667 "base_tree is not a tree oid" UserInfo=0x95ad7f0 {OCTClientErrorOAuthScopesStringKey=repo, user, OCTClientErrorHTTPStatusCodeKey=422, NSLocalizedDescription=base_tree is not a tree oid, OCTClientErrorRequestURLKey=https://api.github.com/repos/czeluff/czGroceries/git/trees, NSUnderlyingError=0x91a97a0 "Expected status code in (200-299,304), got 422"}

I am testing in the simulator, and my repo is located here. https://github.com/czeluff/czGroceries

In GCYGroceryListViewModel.m you have this code:

[[[[self.didBecomeActiveSignal
    flattenMap:^(GCYGroceryListViewModel *viewModel) {
        return [[[[viewModel.signInAction
            signalWithValue:nil]
            ignoreValues]
            concat:[RACSignal return:viewModel]]
            catchTo:[RACSignal empty]];
    }]
    flattenMap:^(GCYGroceryListViewModel *viewModel) {
        return [[[viewModel.loadItemsAction
            signalWithValue:nil]
            concat:[RACSignal return:RACUnit.defaultUnit]]
            catchTo:[RACSignal empty]];
    }]
    take:1]
    subscribe:nil];

I'm curious in particular about the subscribe:nil. I wondered how you handled this type of need to execute some actions/signals without really needing to subscribe to their values. I was doing the same thing with subscribe:nil but felt a little dirty about it. Anything wrong with this practice?

This change would appear to be the culprit. The list is loaded only once, when the repository is assigned to initially.

Allow the names and stores of items already in the list to be edited from within the app.

Explain the project's:

• Purpose
• Basic functionality
• Underlying technology
• Grocery list format (and setting up the list repo)
• UserSettings.xcconfig

I created a file in my repo as suggested and added 1 item. I added "Wheat Bread," then quit the simulator and re-built & ran a debug session in the simulator. The first thing shown in the simulator was this (before I touched anything):

It contains "Milk," and "Wheat Bread," but the former is hidden.

where is the definition of rcl_presentViewController: animated:? not found in your project and reactiveCocoalayout

Allow stores to be added and removed from the main screen.

Show off dat MVVM.

Hey Justin - great app, learnt tons of RAC tricks by reading the source, but I just tried to get it running on my Mac and can't get it to compile :) / :(

I've:

• cloned
• created a new, non-empty repo & a new GitHub app
• filled in the UserSettings.xcconfig file
• ./script/bootstrap'd
• Build

The error I get is in GroceryList-Prefix.pch - 'UIKit/UIKit.h' file not found. If I comment out that line I get the same error when it gets to MobileCoreServices.h.

I'm still new to iOS development so not sure if the error is a project config error or something on my end - any ideas?

I see that the frameworks are being included in the project settings; not sure what to do next.

Thanks!

I'm trying to run this project and I'm getting this error? any clues?

There shouldn't be any need for the user scope.