Git Product home page Git Product logo

geokit's People

Contributors

bamarni avatar jsor avatar koenpunt avatar luka-dev avatar peter279k avatar rossity avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

geokit's Issues

bumped into a shrink call on a BoundingBox that yielded a bbox that goes around the globe

believe the issue is with BoundingBox::shrink + BoundingBox::transformBoundingBox

public function shrink(Distance $distance): BoundingBox

private static function transformBoundingBox(BoundingBox $bbox, float $distanceInMeters): BoundingBox

example input to recreate:

$oBBox = BoundingBox::fromCoordinates([-118.45982654727163,33.858738223292775,-118.27313345274219,34.19377442763222]);
$fShrinkDistance = Distance::fromString('12km');
$oShrinkBBox = $oBBox->shrink($fShrinkDistance);

$oShrinkBox coords (note NE x is < SW x)
    [$oShrinkBox] => Geokit\BoundingBox Object
        (
            [southWest:Geokit\BoundingBox:private] => Geokit\Position Object
                (
                    [x:Geokit\Position:private] => -118.32986907162
                    [y:Geokit\Position:private] => 33.96665666694
                )

            [northEast:Geokit\BoundingBox:private] => Geokit\Position Object
                (
                    [x:Geokit\Position:private] => -118.40360502789
                    [y:Geokit\Position:private] => 34.085855983985
                )
        )

Screen Shot 2021-03-09 at 2 08 52 PM

the original method when passed with a positive shrink distance can result in minLon > maxLon. I added the additional check on lat just to be clear. Maybe there's something more elegant :D

below is my local fix

        /**
         * @see http://janmatuschek.de/LatitudeLongitudeBoundingCoordinates
         */
        private static function transformBoundingBox(BoundingBox $bbox, float $distanceInMeters): BoundingBox
        {
            $latSW = deg2rad($bbox->southWest()->latitude());
            $lngSW = deg2rad($bbox->southWest()->longitude());

            $latNE = deg2rad($bbox->northEast()->latitude());
            $lngNE = deg2rad($bbox->northEast()->longitude());

            $angularDistance = $distanceInMeters / Earth::RADIUS;

            $minLat = $latSW - $angularDistance;
            $maxLat = $latNE + $angularDistance;
            $fMinLat = min($minLat,$maxLat);
            $fMaxLat = max($minLat,$maxLat);
            $minLat = $fMinLat;
            $maxLat = $fMaxLat;

            $deltaLonSW = asin(sin($angularDistance) / cos($latSW));
            $deltaLonNE = asin(sin($angularDistance) / cos($latNE));

            $minLon = $lngSW - $deltaLonSW;
            $maxLon = $lngNE + $deltaLonNE;

            // asin can be neg Mark E.
            $fMinLon = min($minLon,$maxLon);
            $fMaxLon = max($minLon,$maxLon);
            $minLon = $fMinLon;
            $maxLon = $fMaxLon;

            $positionSW = Position::fromXY(rad2deg($minLon), rad2deg($minLat));
            $positionNE = Position::fromXY(rad2deg($maxLon), rad2deg($maxLat));

            // Check if we're shrinking too much
            if ($positionSW->latitude() > $positionNE->latitude()) {
                $center = $bbox->center();

                return BoundingBox::fromCornerPositions($center, $center);
            }

            return BoundingBox::fromCornerPositions($positionSW, $positionNE);
        }

final result calling above vs shrink:
shrunken bbox coords -> [-118.40360502789,33.96665666694,-118.32986907162,34.085855983985];
Screen Shot 2021-03-09 at 1 55 53 PM

new release?

Hi,

Just requesting a new release, I'm having to use dev-master via composer at the moment because 1.3 doesn't have methods like circle(). A 1.4 release would make me feel better about future composer updates.

Thanks for the awesome library!

New Zealend Bbox throw Exception

bbox data:
[east] => -175.836411
[south] => -52.607582
[north] => -29.241097
[west] => 165.883774

Exception:
Bounding Box south-west coordinate cannot be north of the north-east coordinate

Autoloading not picking up your class

Hey mate,

Thanks for this library. I was trying to use it in Laravel and have installed it via composer.
However, dumping my auto load does not pickup your library at all.

Any idea why it wouldn't?

Cheers

Geometry interface + GeoJSON

What do you think of this Interface :

interface Geometry {
    public static function input($input) : Geometry;
    public function toGeoJson() : array;
}

We could standardize normalize method, and provide a toGeoJson() converter (good for api).

Potential Polygon Bug?

I'm trying to test if a point is inside a polygon and I'm wondering if I have found an issue or perhaps I've misread the docs. Would really appreciate your help here. I included a couple of dump and die's to show that my code appears to be correct. Thanks ahead of time.

     use Geokit\Polygon;
     use Geokit\Position;

    $polygon = new Polygon(
            new Position(125.2, 5512),
            new Position(136.6, 5512),
            new Position(139.7, 3880),
            new Position(139.7, 3307),
            new Position(129.9, 3307),
            new Position(122, 4409),
        );
        $envelope = $polygon->close();
     dd($polygon);
     //Output
        array:7 [
        0 => Geokit\Position^ {#36
            -x: 125.2
            -y: 5512.0
        }
        1 => Geokit\Position^ {#1282
            -x: 136.6
            -y: 5512.0
        }
        2 => Geokit\Position^ {#1289
            -x: 139.7
            -y: 3880.0
        }
        3 => Geokit\Position^ {#1290
            -x: 139.7
            -y: 3307.0
        }
        4 => Geokit\Position^ {#1291
            -x: 129.9
            -y: 3307.0
        }
        5 => Geokit\Position^ {#1292
            -x: 122.0
            -y: 4409.0
        }
        6 => Geokit\Position^ {#1293
            -x: 125.2
            -y: 5512.0
        }
        ]

    $point =  new Position(125.98652772609, 5374.0);
     dd($point)
    //Output
     Geokit\Position^ {#1295
       -x: 125.98652772609
       -y: 5374.0
     }
     //This point should appear inside the $envelope.
     //I've tested this in Excel as well 
     //as a Javascript geometric package to make sure.

     $envelope->contains($point);
     //false

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.