jshttp / methods Goto Github PK

Largely forgotten but defined in RFC 2068.

It would be helpful to know when adding this dependency is necessary.

or add me as maintainer

It'd be nice if requiring this with Browserify didn't incur 5000 lines of extra dependencies (E.g. http, which in turn requires buffer, etc.) for people who are trying to keep builds smaller. It's as simple as adding this to the package.json:

  "browser": {
    "http": false
  }

The only reason this is an issue over a PR, however, is that returning the browserified http module methods could be seen as a feature - so I leave this in the eye of the beholder. Either way, I've copied the list out manually now to avoid the extra debt.

This is:
nodejs/node-v0.x-archive@61002285

so node-methods could use http.METHODS for cutting edge node.js and
a plain list for legacy node.

same usual reasons...
thanks

Hi TJ,

It's been suggested that I file a PR here. This is the original request I filed:

expressjs/expressjs.com#80

The reference documents are the following:

RFC: http://tools.ietf.org/html/rfc5323
Node: https://github.com/joyent/http-parser/blob/master/http_parser.h#L88

Could you please add support for the verb SEARCH? Thanks in advance!

http://www.iana.org/assignments/http-methods/http-methods.xhtml

PURGE is missing from the list. This method has been supported since node v0.8.0.

Also an unrelated little nitpick, 'SEARCH' should be moved to be between 'PROPPATCH' and 'UNLOCK' to match the order in http_parser.h.

Hi, any chance you could add a clear license on this? The only thing I can spot is "MIT"
in the json packaging file...

Cheers!

The fallback methods in https://github.com/jshttp/methods/blob/master/index.js#L22 do not encompass the new QUERY method.

We could use code to include it if the Node version you're running includes it, but I think a new major would be more appropriate if we have differences in http.METHODS between node majors. Not sure this has ever happened before.

See expressjs/express#5615

related: expressjs/express#5628