jschaedl / bav Goto Github PK

In library/Bav/Backend/BankDataResolver.php at line 19:
"array_key_exists" has to be used instead of "in_array".

Ich möchte die BIC für etliche Bankleitzahlen ermitteln. Dies schlägt bei folgender BLZ fehl: 63020450

Lt. blz_2014_03_03_txt.txt gibt es für 63020450 eine Nachfolge-BLZ 63020086.

Sollte hier getBic die korrekte BIC ermitteln können? (so dass die BIC von dieser Nachfolge-BLZ herangezogen wird)

Aktuell tut es dies leider nicht.

use Bav\Bav;

$bav = Bav::DE();
$bank = $bav->getBank("63020450");
$bic = $bank->getMainAgency()->getBic();

Obiges führt aktuell zu folgender Fehlermeldung:

Fatal error: Uncaught exception 'Bav\Bank\Exception\UndefinedAttributeException' in
/kunden/108014_96450/rp-hosting/10343/12345/domain/helper/iban/vendor/jschaedl/bav/library/Bav/Bank/Agency.php:100 
Stack trace: #0 /kunden/108014_96450/rp-hosting/10343/12345/domain/test.php(13):
Bav\Bank\Agency->getBic() #1 {main} thrown in 
/kunden/108014_96450/rp-hosting/10343/12345/domain/helper/iban/vendor/jschaedl/bav/library/Bav/Bank/Agency.php 
on line 100

I did the following:

$bav = Bav::DE();
$bank = $bav->getBank('38651390');

This triggers the following Exception:

Fatal error: Uncaught exception 'LogicException' with message 'Start and end should be defined for bankId=37050299 (exception=The contextCache object should exist!)' in vendor/jschaedl/bav/library/Bav/Backend/Parser/BankDataParser.php:95
Stack trace:
#0 vendor/jschaedl/bav/library/Bav/Backend/BankDataResolver.php(37): Bav\Backend\Parser\BankDataParser->resolveAgencies('37050299')
#1 vendor/jschaedl/bav/library/Bav/Backend/BankDataResolver.php(20): Bav\Backend\BankDataResolver->resolveBankData('38651390')
#2 vendor/jschaedl/bav/library/Bav/Bav.php(38): Bav\Backend\BankDataResolver->getBank('38651390')
#3 test.php(6): Bav\Bav->getBank('38651390')
...

Another bank code triggering this behavior is for example 38650000. I had a quick look at the BankDataParser and the data file, but I am not sure what triggers the behavior above.

Hi,
i'm using the old bav-0.26 from malkusch.
Is there any chance for a short "how to upgrade" to this more recent version?
Or maybe is there already something like that?

Thanks
kscholz

Hi,

can you please use semantic versioning according to the rules of http://semver.org for future releases? (for example "1.0.0" instead of "v1.0")

That enables users to use this library a lot easier. Releases with minor and patch level changes can be used without excessive manual testing by just requiring ~1.0 in the composer.json, because they should be backward compatible.

Thanks
Gordon