jrozner / ashirt-rs Goto Github PK

We should provide both an async and blocking api, similar to how reqwests does. It probably makes sense to look at how they implement it and do something similar. It would be nice if we could re-use the async implementations for the blocking to avoid having to duplicate the implementation.

Currently the server still returns this and it is used for the /api/operations/:id endpoint. It's unclear if this is ever actually needed. It seems like it only exists to get the slug name of an id that we already have. Given that we've elsewhere moved entirely to slugs this maybe able to go away now and definitely will be able to go away in the future.

Wait until we have an answer for ashirt-ops/ashirt-server#467. The only place this seems like it might be used is in the desktop app.

It's not clear what the best way to handle this is given that there likely isn't much that can be done as unit tests. There might be some good mocking libraries that we can leverage but it probably doesn't actually make sense since we really want to run integration tests. We could potentially spin up ashirt with docker compose in the test runner and have it communicate with the server. We'd need to ship some default key pairs with the seed data which I don't believe we currently do.

Given the relatively small amount of code it probably makes sense to just build a native version in each of the languages that we need to support. It would be nice to have a C compatible library that other projects can link against. We could also use language bindings for other languages (python, ruby, node, etc.) but we should probably wait until there is real desire. Java would be relatively easy with the JNI crate but the main use case for a Java implementation is likely going to be burp which would make this difficult to distribute.