jrallison / rollout_ui Goto Github PK

The Rollout UI gem is over a year out of date. It does not work with rollout 1.2. Can we get an update please? :)

Thanks.

If you use redis namespace, redis.smembers(:features) will not work. I changed it to @rollout.features, but it breaks a bunch of tests.

I'm not entirely sure why we need to have #add_feature in wrapper.rb, so I'm really having trouble refactoring it. What's the reason behind using redis.smembers(:features) instead of @rollout.features? Thanks!

This would restrict access to only users who know the username and password. Presumably we could add other auth strategies but this seems the bare minimum.

I mounted rollout_ui within my rails 3.2.8 app but it seems that the engine is not able to find the proper layout or view templates. Instead of rendering the layout application/rollout_ui/application.html.erb, it is actually rendering my layout within my application.

I am using rollout_ui 0.2.1.

thx!

-karl

Using this

source 'https://rails-assets.org' do
  gem 'rails-assets-jquery-ujs'
end

in your main app will overwrite the use of the local jquery-ujs.js file located in rollout_ui/lib/rollout_ui/engine/vendor/assets/javascripts/jquery-ujs.js. This can cause problems because the latest jquery-ujs.j file demands a jquery version higher then 1.8.0

I updated all my gems this week and I had a problem with rollout and rollout UI.

That error showed up in the view:

undefined method `join' for #<Set: {}>
/Users/sdeziel/.rvm/gems/ruby-2.2.4@express/gems/rollout_ui-0.3.0/lib/rollout_ui/engine/app/views/rollout_ui/features/_feature.html.erb:31

The faulty line:

<input class="users" type="text" name="users[]" value="<%= feature.user_ids.join(",") %>" data-placeholder="Enter User ID" />

I looked into rollout changes and since v2.2.1, Set is used instead of Array for users.
fetlife/rollout@5b2615e

Incorrect config.ru, rails 3.0.9:

run Rack::URLMap.new \
  "/" => MyApp::Application,
  "/admin/rollout" => RolloutUi::Server.new

Correct, as shown in readme here and on rollout gem:

# fixes: undefined method `smembers' for nil:NilClass 
$redis   = Redis.new
# fixes: uninitialized class variable @@rollout in RolloutUi 
$rollout = Rollout.new($redis)
RolloutUi.wrap($rollout)

run Rack::URLMap.new \
  "/" => MyApp::Application,
  "/admin/rollout" => RolloutUi::Server.new

Hi all,
Since this project is not being maintained anymore,
I want to inform all the people that care about rollout gem that we @ Fiverr built a new client app for managing our rollouts.
https://github.com/fiverr/rollout_dashboard/

The code for active? in monkey_patch.rb always adds a feature to the Redis features set.

Is there any reason why this can't be done just once (I'm thinking on keeping a ruby Set or Hash with the features that have already been added).

Redis is fast, but doing nothing is still faster.

I could submit a pull request for this.

Hi,

I'm interested in adding support for modifying groups - particularly adding/removing users from groups, and maybe also being able to add/delete groups, although this is much less important. Have their been any discussions about how this functionality might be achieved already? I was thinking of adding a second page that would list groups and allow their modification - which would also mean adding some navigation to the layout.

Our specific use case is the Sinatra app, so I'd probably look at adding these features there in the first instance (as I can see the server's views are managed separately from the rails engine). Am I right in thinking test coverage for this area is low at the moment? If so, and I were to add some, is rspec + capybara the preferred method, or would cucumber be better?

Basically, any guidance on how this contribution would 'fit' would be happily received.

Cheers,

Sam