jpstevens / circleci Goto Github PK

Can you make the hostname a configurable option so this can be used against the API endpoint of private server instances of CircleCI?

is this implemented?

This library works only with Github with the current implementation, as it uses URLs like this:

https://circleci.com/api/v1.1/project/:username/:project/tree/:branch

Following the documentation, the VCS can be specified by using URLs like:

https://circleci.com/api/v1.1/project/:vcs-type/:username/:project/tree/:branch

Not providing the vcs-type path parameter makes CircleCI consider github as VCS.

A way to fix this would be to add the vcs-type config value and using it in the functions where it is needed.

/cc @jpstevens

There seems to be an issue with the distribution uploaded to the npm repository and I can't require circleci:

Error: Cannot find module 'circleci'

If you add circleci to the package.json of another project, npm install and then try requiring it you should be able to replicate the issue.

The README mentions that this client does not support optional build parameters. This would be super-useful for me, do you plan to add that support? Do you expect it will be difficult to do? I'd try it, but I've never worked in coffeescript before.

What licence is this under please?

could you fix the build (https://travis-ci.org/jpstevens/circleci)?

IMO without it nobody should use this library

The index script should be located here:
https://github.com/jpstevens/circleci/blob/master/package.json#L5

but in the NPM ignore file this file is ignored.

Jack, please, can you do a fresh installation of this lib to see what's happening?

When I install this lib as a dependency all I can find in node_modules/circleci is one folder (node_modules) and 3 files: circle.yml, package.json and README.md you somehow ignored the necessary files :D

Cheers