jpcercal / environment Goto Github PK

It would be great if you could pass a second argument as the default value, if the env var isn't set.

Currently, I have to do this:

$enableIndexing = getenv('ENABLE_INDEXING') !== false ? Environment::get('ENABLE_INDEXING') : true;

Would be great if I could just do:

$enableIndexing = Environment::get('ENABLE_INDEXING', true);

Using Environment::get(), one can obtain variables not included in Environment::getAll(). This odd behavior is caused by EnvironmentVariable::getEnvironmentVariables() searching only $_ENV and $_SERVER, whereas EnvironmentVariable::getEnvironmentVariable() searches $_ENV, $_SERVER, and getenv().

I suggest including a call to getenv() inside of EnvironmentVariable::getEnvironmentVariables() for the purpose of pulling in any variables that may not be included in $_ENV (such as when variables_order is set to "GPCS" thus excluding $_ENV).

I am going to make this code change and submit a PR.

My use case is I want to get an array of all env vars that start with PHP_INI_, and loop through them with ini_set.

If I could get an array of all env vars, that would help.

No need for this.