Git Product home page Git Product logo

variable-fonts's People

Contributors

davelab6 avatar jpamental avatar kennethormandy avatar litherland avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

variable-fonts's Issues

Additional 3rd party content

Finish up home page

Just putting this here as a nudge. I don't have access to the design, but I'm happy to help if I can. This is the last outstanding bit (apart from wanting the toggles) so just don't want to leave it hanging out there.

font-width or font-stretch?

I could not find any reference to font-width used in the font stretch example

Text:

p {
font-stretch: 89%;
}

Dynamic example:
.text {
font-width: %;
}

Web debugger:

font-stretch: calc( var(--text-vf-wdth) * 1%);

not font-width

Integrate Gulp build process to include Material Design components

Working through the process of setting up a build process that combines Gulp and Jekyll processes so we can include Material Design components.

This is now mostly complete. The Gulp process runs entirely in the local environment and then Jekyll runs as it normally does both locally and upon deployment to the gh-pages branch.

Updating "Slant & Italics" section, now that Recursive has Slant & Cursive axes (and no Italic)

With Release 1.046/1.047 of Recursive, the family no longer accurately falls under the description of "Slant & Italics," largely because after several conversations with Dave Crossland and DJR, I've come to the conclusion that a font probably shouldn't contain both Slant & Italic axes – or at least, it didn't make sense for Recursive.

I wrote more about the issue in notes on the topic of Slant & Italic axes in Recursive.

The main thing: I updated the Italic axis to "Cursive," because ital 1 should result in the "Italic" style of a typeface. The axis I had didn't really do that – instead, it tweaks cursive letterform substitution behavior along the Slant axis.

I don't think I can totally rewrite this section in a way that everyone would be happy with (especially without chatting it over, first). However, a few things that I believe should change are:

  • The slnt axis should be -15 to 0 (it is a negative range). It shouldn't be capped at 10 degrees. Also, it only gets positive numbers if it is being called from the declaration font-style: oblique XXdeg.
  • ital should change to CRSV in this section
  • CRSV should have a step of 0.5, so that its default "auto substitution" setting can be the default shown. This allows Cursive alternates to auto swap in at slnt -14. Setting CRSV to 0 prevents this (letters stay roman up to slnt -15, and setting CRSV to 1 asserts cursive alternates at any slant.
  • I'm not sure if it's worth saying, but once browsers properly support font-style for variable fonts, the Slant axis will work quite well with this property – no font-variation-settings required unless people want to adjust the CRSV axis. Of course, this will take months (at minimum), so maybe it's fine to recommend font-variation-settings font now, and update later when font-style is better supported.

Of course, it's possible we should just remove this "Slant & Italics" section entirely, and (hopefully) move this slnt+CRSV example up to the "Slant" section. For one thing, "Slant & Italics" is under "Registered Axes," which is no longer true. Also, even DJR said that Roslindale Italic Variable Beta, in combining slnt+ital, doesn't do things in a way he would likely do them today (paraphrasing his words). So, this probably isn't a thing that we really need to be advocating for. Instead, we should try to help people understand when Slant is useful vs when Italic is better.

I've started a PR to update the site to Recursive 1.047, and start making a few of these basic changes:

#204

Next steps would be discussing what we do to update the content. Do we try to update a little bit, or a lot?

Drop future syntax for variable font hints

Thank you for the excellent resource!

The current css-fonts-4 spec has an updated syntax for variable font hints: format(woff2) tech(variations). Neither this syntax (which, due to CSS parsing rules needs to be added as a second src declaration), nor previous incarnations (such as the one presented on the website) has any browser support. On the flipside, format('woff2-variations') is supported now and hopefully forever.

I believe it would be better to drop the new syntax altogether.

Fix links in nav

Links in nav still directing to googlefonts.com, and thus returning 404s.

Add back in “Variable fonts in the Google Fonts UI” section when ready

There is currently a placeholder for content for the https://googlefonts.github.io/variable-fonts/implementing-variable-fonts/#gf-ui section:

Screen Shot 2020-02-21 at 11 58 37 AM

This section is also mentioned and linked to at the top of the page:

Screen Shot 2020-02-21 at 12 48 51 PM

It would be good to remove this placeholder momentarily, so the site doesn't feel like anything is overtly missing, and then add the section back when the content that @jpamental is preparing for it is ready (likely Thursday next week.)

@kennethormandy please could you comment out those 2 bits for now

Irin to provide color palette and design examples

They can be screenshots or Sketch files. We already have Material components being pulled in, so it's mainly a question of identifying color palette and which components are being used in what context so we can play off the same ideas.

Replace italic figure sample word

The italic figure sample word is Good but this doesn't have an a or g in it, which the text explicitly mentions, so the sample word should be updated

Screen Shot 2020-02-21 at 11 51 32 AM

Narrow viewport footer FoGF element is grey on black

The narrow viewport's footer's Friends of Google Fonts element is grey on black, unlike the rest of the footer and unlike the wider viewport style. I suggest to just make that narrower element style the same as the wider style.

Wide (desktop) viewport:

Screen Shot 2020-02-29 at 10 30 46 AM

Narrow (tablet) viewport:

Screen Shot 2020-02-29 at 10 29 34 AM

Color contrast too low in 'drawer' highlighted page

Nice updates on the Material components (much cleaner than my initial integration), but one issue that surfaced is that the color contrast is too low to pass WCAG AAA size/contrast (one of the mandates for the site).

Screen Shot 2020-02-18 at 7 13 03 PM

Also noticed that it needs to be wired in to the color variable names that switch when 'dark' mode is enabled.

Screen Shot 2020-02-18 at 7 24 39 PM

variable axis glyph substitution not working on Safari; can be fixed with hack

In the opening banner, letters like r only have their correct letterforms in Chrome and Firefox. On Safari, they have the incorrect letterforms, because Safari has a bugs around rvrn.

Letterspacing block rvrn: https://bugs.webkit.org/show_bug.cgi?id=206898

&

Single-character strings block rvrn (that seems to be the main culprit here): https://arrowtype.github.io/recursive/gsub-bug-and-hack_fix-safari/index.html

On Chrome & Firefox, letters have this appearance:

image

On Safari, they have this appearance (the r, i, and l all have their default forms rather than their mono-specific alternates):

image

One hack to make things work is to apply a stylistic set that does nothing, such as ss19:

image

Another hack is to add a zero-width space into each span.

Global layout has errant quote shifting layout

It seems that an errant quote is messing up the layout of all pages. This is more noticeable on pages with backgrounds, such as the "Designing with Variable Fonts" and "Implementing Variable Fonts."

image

image

image

Browsers: macOS Chrome, iOS Safari

Third-party JS in use

Hi there,

There are two JS libraries in use: one Google project (Prettify) and FontFaceObserver. I've cleaned up the code organization to put them both in a top-level directory third_party and have included the license files.

Evan - hoping you're the right Evan to tag in on this! Dave Crossland sent me an email saying these should be approved by you. I'm assuming that the Google project will be fine, and am hoping the same will hold true for Font Face Observer. That is being used to better manage the font loading/display experience for the site.

Please don't hesitate to get in touch if you need more clarification.

Thanks,

Jason

Google Code Prettify
https://github.com/google/code-prettify

Font Face Observer
https://github.com/bramstein/fontfaceobserver

Continuous Integration

@jpamental small question, is this site using the built-in Jekyll continuous integration feature called Github Pages; if so, can then there be no master branch, just a gh-pages branch?

"Slant" section should use font-variation-settings until browsers support font-style

Browsers currently have very limited support for font-style and variable fonts.

Test page: https://arrowtype.github.io/vf-slnt-test/slnt-ital-tests/index.html

So, the example of Inter with font-style doesn't work for me, on any current stable browser release. Therefore, I feel it should probably be changed to reflect that state of things, or it may appear that the site of font is broken to users, and they might be confused if they try to use that technique themselves.

Screen capture of the issue (Click to expand)

Kapture 2020-04-04 at 22 51 45

Need screenshots and details of new GF UI

In order to have instructions on the Implementation page on how to get VFs through the main UI we need to get access to some screenshots or the actual UI so we can create them

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.