joswha / secure-coding-handbook Goto Github PK
View Code? Open in Web Editor NEWWeb Application Secure Coding Handbook resource.
Home Page: https://vladtoie.gitbook.io/secure-coding/
Web Application Secure Coding Handbook resource.
Home Page: https://vladtoie.gitbook.io/secure-coding/
Hello,
I am a bit concerned by the example presented.
Indeed the hash function is likely to take some time and therefore even if the email is not leaked by the error message, it is instead leaked by the difference of time the server took to respond.
A better way in my opinion would be to compute an hash in all cases like:
// Validating the existence of a user with the specified email.
const existingUser = await User.findOne({ email });
if (!existingUser) {
let _ = await bcrypt.compare(password, "fake password used to counter timing attack");
return res
.status(401)
.json({ errorMessage: "Invalid email or password." });
}
// Validating the password attributed to that User object with the passwordHash
// from the database.
const passwordCorrect = await bcrypt.compare(password, existingUser.passwordHash);
if (!passwordCorrect) {
return res
.status(401)
.json({ errorMessage: "Invalid email or password." });
}
I understand the extra line can undermine the point about error messsages which is the crucial first step, but I feel like at least an extra note about it should be added at the end.
A declarative, efficient, and flexible JavaScript library for building user interfaces.
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
The Web framework for perfectionists with deadlines.
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. ๐๐๐
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
We are working to build community through open source technology. NB: members must have two-factor auth.
Open source projects and samples from Microsoft.
Google โค๏ธ Open Source for everyone.
Alibaba Open Source for everyone
Data-Driven Documents codes.
China tencent open source team.