daisiemainland_ms's Introduction
daisiemainland_ms's People
daisiemainland_ms's Issues
Reduce jargon in summary
RJCB: To quote JOSS guidelines: 'Begin your paper with a summary of the high-level functionality of your software for a non-specialist reader. Avoid jargon in this section' (emphasis mine). I feel there is too much jargon in this section, and here is my suggestion to reduce it
Remove detail from simulation algorithm section
RJCB: I think the DG algorithm can be explained in less detail, to make room to show what the package does, e.g. by showing some code and resulting figures
Review on 2022-04-21
No vignettes
After
remotes::install_github("joshwlambert/DAISIEmainland")
and checking the vignettes, I find there are no vignettes:
> vignette(package = "DAISIEmainland")
no vignettes found
I think a devtools::build_vignettes()
for the package would fix this, but building vignettes -as far as I can remember- changed and was finicky.
Too much words
I quote from joss_guidelines.md
:
The paper should be between 250-1000 words. Authors submitting papers significantly longer than 1000 words may be asked to reduce the length of their paper.
Here we have approximately 1330 words:
wc paper.md --words
1330 paper.md
References to vignettes in the package is preferable to raw code
I would prefer there to be no code in the paper other than where unavoidable. Instead I suggest we use vignettes in the R package to allow ourselves to give a much more detail exposition of the code.
Make paper less detailed
RJCB: I feel the paper is too detailed in general. I suggest to show what the package does and explaining from there. I suggest to show these aspects, that I quote from the summary:]
(1) simulate the evolutionary history on islands, (2) visualise that history,
(3) calculate and plot summary metrics of the simulated data
Review draft on Monday 2021-12-27
- Use own branch
- Create PR to Josh
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. ๐๐๐
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google โค๏ธ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.