Comments (5)
You can use BigNumber.From to parse it on the response in your code. right now in the lib it just returns the nine class version.. would be nicer if it parsed for you for sure on cases where _isBigNumber = true
Will look at doing that but for now parse it yourself once result comes back
from ethereum-multicall.
You can use BigNumber.From to parse it on the response in your code. right now in the lib it just returns the nine class version.. would be nicer if it parsed for you for sure on cases where _isBigNumber = true
Will look at doing that but for now parse it yourself once result comes back
Hi! As we have introduced an options parameter into the call method, we could add a new parameter to return bignumbers instead of strings?
from ethereum-multicall.
For sure great idea!! be my guest to do a PR @jsertx
from ethereum-multicall.
I have seen that the issue is on the Utils.deepClone when building returnObjectResult pushing to callsReturnContext array in the following lines:
ethereum-multicall/src/multicall.ts
Line 165 in 80ae156
ethereum-multicall/src/multicall.ts
Line 209 in 80ae156
ethereum-multicall/src/multicall.ts
Line 237 in 80ae156
We could release a new minor version: adding the extra options parameter returnBigNumber
to parse it with false
as default to not break current implementations.
And maybe, in a major version add that parsing option default to true, so removes friction for first time users.
from ethereum-multicall.
Nice find yeah that will nuke the big number class! And now it’s in the wild we can’t really break it! I would say yes do the returnBigNumber option and make it parse stuff back and then as you say we can bring in a breaking change on the major! We can guide the docs to this as well! PR welcome!
from ethereum-multicall.
Related Issues (20)
- Can we get multicall on Core Chain Mainnet HOT 1
- Accessing Multicall3 Contract Methods HOT 2
- returnValues is an array of values instead of an array of objects HOT 1
- Multicall fails on Arbitrum for most RPCs HOT 2
- How to get eth call data
- Does the repository support ethers ^6.6.0 HOT 6
- Multicall for zkSync Era (324) HOT 1
- Base Chain Support HOT 1
- Cleanup non issue
- Multicall get balances of a native currency in a wallet HOT 1
- Uncaught (in promise) Error: invalid address (argument="address", value=0, code=INVALID_ARGUMENT, version=address/5.7.0) (argument=null, value=0, code=INVALID_ARGUMENT, version=abi/5.7.0) HOT 1
- Execution failed
- Built-in support for Oasis Sapphire HOT 3
- Archive data request HOT 3
- Polygon zkEvm Mainnet blocNumber issue HOT 1
- Tron Mainnet
- Add support for Manta pacific chain
- Fix for Base Testnet (Sepolia)
- How to make multi call to native token (ETH)? HOT 1
- setting block number is not effecting the request HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ethereum-multicall.