joshbeal / coinbase-ios-sdk Goto Github PK

Probably doesn't work any longer since the update of Cocoapods.

Just thought I would point out that AFNetworking is a dependency and it should be mentioned in the requirements section of the readme.

The isAuthenicated method will only return true after you have called one of the login methods. If you login successfully, then close down the application and relaunch it, calling isAuthenicated will return false, even though the correct auth code, and tokens are stored in the user defaults.

I'm not for sure the best way to solve this problem. Should isAuthenicated, check the data stored in the user defaults, instead of a boolean? You then have the problem of what to do if the access token is expired.

For my own application, I added a hasAuthCode method that checks if an auth code is present. I can use this to determine whether I need the user to login in or not. The access token will then be automatically refreshed when I make any requests. I didn't push this up, as I'm not for sure if this is the best solution for the library.

I was wondering if it was possible to add an option to see the balance of multiple wallets instead of just picking one. I was also wondering if there was a way to implement a button in the drop down menu that would copy a current bitcoin address from your main wallet to the clipboard.

When trying to use the authentication aspect of the library, coinbase says the supplied redirect URI is invalid. If you try to login with the sample application, you will see this error. After reading over the coinbase API documentation, it says for mobile/desktop apps, a redirect URI of urn:ietf:wg:oauth:2.0:oob should be used. I'm guessing the API has changed since the creation this library. I modified the library to use this redirect URI and I am able to authenticate with coinbase, but then the redirect from safari back to the example app is broken. I guessing instead of launching safari, you have to use a UIWebView in the example application and detect when the page changes to get the auth code.

http://coinbase.com/docs/api/authentication#oauth2

How does this compare with https://github.com/coinbase/coinbase-ios-sdk ?