To clarify the purpose of the two files located in the bin/ folder

Issue Type: Bug

Just try to minify a number array:

[
    [
        1,
        2,
        3
    ],
    [
        4,
        5,
        6
    ],
    [
        7,
        8,
        9
    ]
]

And it will keep the spaces between numbers. They are not necessary for syntax, and use a lot of space. I tried formatting a GeoJSON and it didn't get to the minimal size. It's annoying to have to use another command (regex in my case) to delete the remaining spaces.

Extension version: 2.4.9
VS Code version: Code 1.50.1 (d2e414d9e4239a252d1ab117bd7067f125afd80a, 2020-10-13T15:06:15.712Z)
OS version: Windows_NT x64 10.0.18362

To update the readme.md file and the --help argument with the right version to not do it manually

Npm downloads badge from the readme.md file

🚀 Feature Request

Is your feature request related to a problem? Please describe.

• The extension removes all comments including all license information (like the header at the top of the file).

Describe the solution you'd like

• Add some option to keep the license information intact. Either in the extension settings in VSCode, or via some annotation like Google Closure Compiler uses.

/* 
 * @preserve
 * TERMS OF USE - EASING EQUATIONS
 * Open source under the BSD License.
 * Copyright 2001 Robert Penner All rights reserved.
 */

becomes:

/* 
  TERMS OF USE - EASING EQUATIONS
  Open source under the BSD License.
  Copyright 2001 Robert Penner All rights reserved.
 */

Source: https://softwareengineering.stackexchange.com/questions/45033/can-i-minify-javascript-that-requires-copyright-notice

Describe alternatives you've considered

• Copy the header from the original file and insert manually...

Additional context

Not a huge deal, but just an FYI that when I minify a CSS file the minified files has a space at the beginning containing an extra/unnecessary character.

🚀 Feature Request

Is your feature request related to a problem? Please describe.

• Having used the plugin version for a while I noticed only a small number of the options available in said version are available for the client. (Disabling certain file types and all of the Terser options)

Describe the solution you'd like

• A option to specify a json file that will be used to change default values. Command line arguments would override settings from the config.
• For instance:
  minifyall myFile.js -c path/to/config.json -m
  with config.json as:

"terserMinifyOptions": {
	"parse": {
		"bare_returns": true
	}
},
"disableHexadecimalShortener": false

• would have the parser support top level return statements but still minify the hexadecimal color values even if said config file said otherwise.

Describe alternatives you've considered

• While having the options all added as cmd options like -m would work; this would make it harder to understand and work with.

🐞 Bug Report

Describe the bug

Exactly as mentioned in the title:

This Code:

<template>
  <img id="img" alt="">
</template>
<script type="text/javascript">
  var objectFitSupport = 'objectFit' in document.body.style;
  module.exports = function (e,subElements) {
    var ats = $.getAttributes(e);
    var img = subElements.img;
    if (ats.alt) {
      img.setAttribute('alt', ats.alt);
    }
    img.onload = function () {
      $.fastDOM.mutate(function () {
        if (objectFitSupport) {
          img.style.opacity = 1;
        } else {
          e.style.backgroundImage = 'url(' + img.src + ')';
        }
      });
      $.trigger(e, 'load');
    };
    $.extend(e, {
      src: {
        __change: function (v) {
          img.src = '';
          img.style.opacity = 0;
          img.removeAttribute('src');

          /* Solution for Handlebars */
          if ($.contains(v, '{')) {
            console.warn('invalid image url', v);
            return null;
          }

          var obs = $.onViewport(e, function () {
            img.src = v;
            obs.unobserve(e);
          });
          return v;
        }
      }
    });
  };
</script>

<style>
  MDL-IMG {
    display: inline-block;
    overflow: hidden;
    margin: auto;
    position: relative;
    vertical-align: middle;
    background-position: center center;
    background-repeat: no-repeat;
    background-size: cover
  }

  MDL-IMG[fit="contain"] {
    background-size: contain
  }

  MDL-IMG[fit="contain"] img {
    object-fit: contain
  }

  MDL-IMG img {
    border: none;
    position: absolute;
    margin: auto;
    display: block;
    width: 100%;
    height: 100%;
    opacity: 0;
    transition: opacity 0.5s;
    object-fit: cover
  }
</style>

After minifing, this is the resul:

<template><img id="img" alt=""></template><script type="text/javascript">var objectFitSupport='objectFit' in document.body.style; module.exports=function (e,subElements){ var ats=$.getAttributes(e); var img=subElements.img; if (ats.alt){ img.setAttribute('alt', ats.alt);} img.onload=function (){ $.fastDOM.mutate(function (){ if (objectFitSupport){ img.style.opacity=1;} else{ e.style.backgroundImage='url(' + img.src + ')';}}); $.trigger(e, 'load');}; $.extend(e,{ src:{ __change:function (v){ img.src=''; img.style.opacity=0; img.removeAttribute('src'); if ($.contains(v, '{')){ console.warn('invalid image url', v); return null;} var obs=$.onViewport(e, function (){ img.src=v; obs.unobserve(e);}); return v;}}});};
</script><style>MDL-IMG{ display:inline-block; overflow:hidden; margin:auto; position:relative; vertical-align:middle; background-position:center center; background-repeat:no-repeat; background-size:cover} MDL-IMG[fit="contain"]{ background-size:contain} MDL-IMG[fit="contain"] img{ object-fit:contain} MDL-IMG img{ border:none; position:absolute; margin:auto; display:block; width:100%; height:100%; opacity:0; transition:opacity 0.5s; object-fit:cover}
</style>

Your environment

• OS: Windows 10
• Node version: 12.19.0

Such as --sufix .min

🐞 Bug Report

Describe the bug

Version 2.4.13 on VS Code 1.52.1

On JSON which has string value, space in value is removed on minify.
Example
{
"headers": "Content-Type:application/json\nAccept: application/json",
"body": "{"login":{"username": "${username}","password": "${password}"}}"
}
Space in values are removed on Minify. Example, after Accept:, between username, between pasword...
This is after beautified, minified JSON. (problem is creted during minify operation
{
"headers": "Content-Type:application/json\nAccept:application/json",
"body": "{"login":{"username":"${username}","password":"${password}"}}"
}

Your environment

• OS: Windows 10
  MinifyAll: 2.4.13
  VS Code: 1.52.1 user install

in a CSS file:

• before minified:

.className {
  width   :   0%   ;
}

• after minified:

.className{width :0%}

• expected:

.className{width:0}

The space between property name width and colon : is not necessary.

And the unit of 0% is unnecessary, too. It should be just 0.

eg:

<script>
    function test($targetForm, data) {
        $.map(data, function (value, key) {
            if (key == "A") {
                alert('A')
            };
            // if (key == "B") {
            // }
        });
    }
</script>

will get the code:

<script>function test($targetForm, data){ $.map(data, function (value, key){ if (key=="A"){ alert('A')}; // if (key=="B"){ //}});} </script>

🐞 Bug Report

Describe the bug

PHP minification may create invalid syntax. When a ';' is directly in-front of a '}' the ';' is removed creating a syntax error.

Is this a regression?

Not as far as I'm aware

To Reproduce

Minify:

<?php
if(true){$var=1;$var2=2;}
if(true){$var=1;$var2=2; }
?>

Expected behaviour

<?php
if(true){$var=1;$var2=2;}
if(true){$var=1;$var2=2;}
?>

or

<?php $var=1;$var2=2;?>

Observed behaviour

<?php
if(true){$var=1;$var2=2}
if(true){$var=1;$var2=2;}
?>

Your environment

• Plugin version: v2.10.0

Describe the bug
Whenever you minify a JSON document, it removes space after comma inside strings while keeping superfluous spaces in other locations and sometimes keep a new line at the end.

To Reproduce
Steps to reproduce the behavior:

1. Open a JSON document
2. Enter something like:

[
  {
    "textStrings": "Welcome, stay a while!"
  },
  {
    "textStrings": "Goodbye, take care!"
  }
]

3. Minify and the output becomes:

[{ "textStrings":"Welcome,stay a while!"},{ "textStrings":"Goodbye,take care!"}
]

Expected behavior
Expected output would be:

[{"textStrings":"Welcome, stay a while!"},{"textStrings":"Goodbye, take care!"}]

🚀 Enhancement Request

Is your enhancement request related to a problem? Please describe.

minify all remove instruction < !--[if mso]> <![endif]-- > in HTML minification.
*

Describe the solution you'd like

preserve < !--[if mso]> <![endif]-- > instruction in minified files
*

Describe alternatives you've considered

Additional context

such as --output myoutputfile.css

This
width: calc(100% - 60px);

Is being minified to this:
width:calc(100 - 60px);

Not sure if this is a bug or a setting, but I can't find this as a setting to change.

How to reproduce :

1. Create a JSON file with following content

{
  "key": "string with : spaces around a colon"
}

2. Minify the document

Expected result:

{"key":"string with : spaces around a colon"}

Actual result:

{"key":"string with:spaces around a colon"}

MinifyAll:
Version: v2.4.9

VSCode:
Version: 1.49.2
Commit: e5e9e69aed6e1984f7499b7af85b3d05f9a6883a
Date: 2020-09-24T16:23:52.277Z
Electron: 9.2.1
Chrome: 83.0.4103.122
Node.js: 12.14.1
V8: 8.3.110.13-electron.0
OS: Darwin x64 18.7.0

Some of my values are not minified correctly.

this one, as example;

@media screen and (min-width: 1025px) { #myid{ box-shadow: #c9c9c9 20px 20px 60px, #ffffff -20px -20px 60px; } }

results in

{box-shadow:#c9c9c9 20px 20px 60px,#ffffff -20px0px -20px 60px}

Haven't tried adding all 4 expected values.

If a space after a colon is inside an html tag, then the space is removed.

For example:
"<p>This is my text: hello world</p>" --> "<p>This is my text:hello world</p>"

Is your feature request related to a problem? Please describe.
When I am using the Minifier to minify my CSS, it removes that unit from the number in my calc() statements. This seems to be a problem in Chrome, where subtractions of numbers without units will cause an "invalid property value" issue. This is the original CSS:

header {
     margin: 0 calc(0px - (50vw - 50%)) 3rem !important;
}

which gets minified to this:

header{margin:0 calc(0 - (50vw - 50%)) 3rem!important;}

Describe the solution you'd like
I would love to have an option where I could specify that I dont want the Minifier to remove units from numbers (a tickbox would suffice).

Describe alternatives you've considered
I am not sure at this point if Chrome is right in reporting an "invalid property value" or if it is a bug. I might file a bug against Chrome later today.