jordanvg / cakephp-menu-helper Goto Github PK

Hi

The view content examples a missing brackets, one near the end of each line.

I faced a problem with multiple static routes. In my case I've this :

Router::connect('/home', array('controller' => 'pages', 'action' => 'display', 'home'));
Router::connect('/lesson', array('controller' => 'pages', 'action' => 'display', 'lesson'));

they point on home and lesson ctp file in my views folder

And my link look like this :

Menu->item($this->Html->link('Home', '/home')); ?> Menu->item($this->Html->link('Lesson', '/lesson')); ?> The problem is that your helper only test the controler and the action. If I click on home, the lesson menu is also active and vice versa.

So I've made some change in your function, maybe need some improvement.

if ($this->params['controller'] == $linkRoutes['controller'] && $this->params['action'] == $linkRoutes['action']) { if (isset($attributes['class'])) { $classes = explode(' ', $attributes['class']); $classes[] = $activeClass; $attributes['class'] = $classes; } else { if(!empty($linkRoutes['pass'][0])){ if($linkRoutes['pass'][0] == $this->params['pass'][0]){ $attributes['class'] = $activeClass; } }else{ $attributes['class'] = $activeClass; } } }

Hope this can help.

Requires

App::uses('Xml', 'Utility');

in MenuHelper.php if the user isn't already using it elsewhere