jordanmontt / illimani-memory-profiler Goto Github PK

If we are keeping the allocated objects, that means that the GC will never free them so the GC measurements are not accurate. Show a warning about that

Hello,

I read in main branch "The release version v0.8 works on Pharo 11 and Pharo 10. To use it on Pharo 12, please use the version that is on the main branch." and I wanted to load it in P11.

So, I changed to the tag (https://github.com/jordanmontt/illimani-memory-profiler/tree/v0.8) and modified the snippet to load that version:

EpMonitor disableDuring: [
	Metacello new
		baseline: 'IllimaniAllocationProfiler';
		repository: 'github://jordanmontt/illimani-memory-profiler:v0.8';
		load ].

I got:

Warning: Package *MethodProxies depends on the following classes:
  InstrumentationEnsurer
You must resolve these dependencies before you will be able to load these definitions: 
  MpInstrumentationUnwinder
  MpInstrumentationUnwinder>>#newWithHandler:receiver:arguments:
  MpInstrumentationUnwinder>>#arguments
  MpInstrumentationUnwinder>>#arguments:
  MpInstrumentationUnwinder>>#handler
  MpInstrumentationUnwinder>>#handler:
  MpInstrumentationUnwinder>>#receiver
  MpInstrumentationUnwinder>>#receiver:
  MpInstrumentationUnwinder>>#value

Please in total size in byte column use humanReadableSIByteSize or a similar method to express to users more meaningful information.

Hi,
Clicking on the GUI, I got:

And DNU seems to be fixed when I inserted the send "contents" like this:

inspectorExtensionContextFingerprint: aBuilder
	<inspectorPresentationOrder: 2 title: 'Context Fingerprint'>

	^ contextFingerprint contents inspectionFullString

Please tell me if my bug description is not precise enough.

Instead of keeping all allocations, a good idea is to sample them to not slow down the application. Also it would be really good to add the real-time memory analysis graph.

The ideas were taken from this link: https://blog.jetbrains.com/dotnet/2022/07/18/how-to-profile-net-code-using-the-dotmemory-plugin-in-rider/

The context fingerprint was removed because it was causing the profiler to break in the latest Pharo 12. One new implementation is needed

Currently, for example for the statistics nodes, there are inspector extensions (presenters). Those presenters are created in methods. I need to put them into separated classes like that I can override the transmission port and have custom transmissions in the inspector.

Hello. I loaded the project with:

EpMonitor disableDuring: [
	Metacello new
		baseline: 'IllimaniProfiler';
		repository: 'github://jordanmontt/illimani-memory-profiler:main';
		load ].

This is a snippet that reproduces it:

IllAllocationProfiler new
	profileFor: 1 seconds;
	open;
	yourself

But also copy-pasted scripts from readme, and a script that I used in the past for Bloc.

My Pharo has 1 or 2 weeks:

Pharo 12.0.0
Build information: Pharo-12.0.0+build.1058.sha.d7fe9c39709fd9c1855730743d80c4c7d49a116d (64 Bit)

Is this information enough?

When there is a lot of data, to open the UI takes a lot of time. Especially the heat-map. It is needed to add a spinner to show to the user that the tool is calculating something.

After it is worth optimizing the speed up things

Here top 10 is not need it, then it should not be visible

Implement a presenter and use a proper object with a data structure that is time efficient

At the moment of writing this issue, the visualizations, like the heatmap and the line plots and the tables, report the number of allocated objects instead of the total allocated memory. It would have more sense to the report the total allocated memory too.

In the new vm the ephemerons are implemented. I need to use them in the profiler to know when an Object is being garbage collected. It can be also used to calculate the hash of the objects. Because we can assume that at that time the object that configurated enough to extract the hash from it. Because when I tried to extract the hash at the allocation time sometimes I was getting erros because the object was failing when calculating the hash

For example, we will probably need to modify the method:

respondToAnnouncement

	illimaniAnnouncer ifNotNil: [
		illimaniAnnouncer when: IllimaniStopedProfilingAnnouncement
			do: [ self refresh ]
			for: self ]

and add an open method to the initialization profiler:

open

	^ IllimaniAllocationProfilerUI new
		  profiler: self;
		  open;
		  yourself

Currently, the sampling only accepts numbers between 1 and 100 (1% to 100%). The mechanism needs to be improved to accept smaller rates. Maybe a user wants to sample 1 of every 1000 objects (0.1%)

The density chart only makes sense when profiling the object lifetimes, not allocation sites

Currently, there are no tests.

EpMonitor disableDuring: [
	Metacello new
		baseline: 'IllimaniProfiler';
		repository: 'github://jordanmontt/illimani-memory-profiler:main';
		load ].

Result :(

Warning: The following definitions had errors while loading.  Press Proceed to try to load them again (they may work on a second pass):
  IllFinalizationProfilerUI
  IllFrequencyHistogramPresenter