Git Product home page Git Product logo

dddm's Introduction

Joran's GitHub stats

dddm's People

Contributors

dependabot[bot] avatar joranangevaare avatar sourcery-ai[bot] avatar

Watchers

 avatar

dddm's Issues

Numbafy!

Numba is great to speed up things even if the implementation is naive

Don't calculate rates for events below threshold

At the moment, we calculate the rates even if they are below threshold (https://github.com/jorana/DirectDmTargets/blob/master/DirectDmTargets/detector.py#L432).
However this is a waste of computing time. E.g. if the calculation uses a spectrum between [0,10] keV and the threshold is at 1 keV we are needlessly calculating 10% of the spectra. As the spectra are quite steep near these low energies, it could well be that the computational gain of doing this smarted may be substantially more than 10%.

Negative rates

Negative rates are nonphysical and cause problems later in the chain. Therefore, we are capping the rates to postive values here:
https://github.com/jorana/DirectDmTargets/blob/111f0e0a5b316f2a5be0d0bd144837b30e654f38/DirectDmTargets/statistics.py#L638

For example, the sniplet below causes negative rates.

energies = np.linspace(0.1, 3.5, 10) *  nu.keV
Shield_SHM = dddm.VerneSHM(location="XENON",
             log_mass=-5.06863087e-01,
             log_cross_section=-3.23810744e+01,
             v_0=2.33211211e+02,
             v_esc=5.42044480e+02,
             rho_dm=5.72576689e-01)
dr = wr.rate_migdal(energies,
                    1 * nu.GeV / nu.c0 ** 2,
                    1e-35 * nu.cm ** 2,
                    halo_model = Shield_SHM)

Installation fails due to conflicting dddm version

Issue description

Hi, users are unable to run dddm due to dependency conflict with numpy package.

As shown in the full dependency graph of dddm, dddm(at level 0) requires numpy (the latest version), while numba(at level 1) requires numpy (<1.23,>=1.18).

According to pip’s "first found wins" installation strategy, numpy==1.23.1 is the actually installed version. However, numpy==1.23.1 does not satisfy numpy (<1.23,>=1.18).

Dependency tree-------


dddm-4.0.0
| +-&corner!version range:*!install version:2.2.1!requirement id:14710149!
| | +-&matplotlib!version range:>=2.1!install version:3.5.2!requirement id:11138679!
| | | +-&cycler!version range:>=0.10!install version:0.11.0!requirement id:13319196!
| | | +-&fonttools!version range:>=4.22.0!install version:4.34.4!requirement id:13319197!
| | | +-&kiwisolver!version range:>=1.0.1!install version:1.4.4!requirement id:13319198!
| | | +-&numpy!version range:>=1.17!install version:1.23.1!requirement id:13319199!
| | | +-&packaging!version range:>=20.0!install version:21.3!requirement id:13319200!
| | | +-&pillow!version range:>=6.2.0!install version:9.2.0!requirement id:13319201!
| | | +-&pyparsing!version range:>=2.2.1!install version:3.0.9!requirement id:13319202!
| | | +-&python-dateutil!version range:>=2.7!install version:2.8.2!requirement id:13319203!
| +-&coveralls!version range:*!install version:3.3.1!requirement id:14710150!
| | +-&coverage!version range:<7.0,>=4.1!install version:6.4.2!requirement id:10249197!
| | +-&docopt!version range:>=0.6.1!install version:0.6.2!requirement id:10249198!
| | +-&requests!version range:>=1.0.0!install version:2.28.1!requirement id:10249199!
| | | +-&certifi!version range:>=2017.4.17!install version:2022.6.15!requirement id:14188026!
| | | +-&charset-normalizer!version range:>=2,<3!install version:2.1.0!requirement id:14188027!
| | | +-&idna!version range:>=2.5,<4!install version:3.3!requirement id:14188028!
| | | +-&urllib3!version range:<1.27,>=1.21.1!install version:1.26.11!requirement id:14188029!
| +-&emcee!version range:*!install version:3.1.2!requirement id:14710151!
| | +-&numpy!version range:*!install version:1.23.1!requirement id:13311901!
| +-&h5py!version range:*!install version:3.7.0!requirement id:14710152!
| | +-&numpy!version range:>=1.14.5!install version:1.23.1!requirement id:13667555!
| +-&hypothesis!version range:*!install version:6.53.0!requirement id:14710153!
| | +-&attrs!version range:>=19.2.0!install version:22.1.0!requirement id:14662090!
| | +-&sortedcontainers!version range:<3.0.0,>=2.1.0!install version:2.4.0!requirement id:14662091!
| +-&immutabledict!version range:*!install version:2.2.1!requirement id:14710154!
| +-&matplotlib!version range:*!install version:3.5.2!requirement id:14710155!
| | +-&cycler!version range:>=0.10!install version:0.11.0!requirement id:13319196!
| | +-&fonttools!version range:>=4.22.0!install version:4.34.4!requirement id:13319197!
| | | +-&brotli!version range:==1.0.9!install version:1.0.9!requirement id:14436980!
| | | +-&brotlicffi!version range:==1.0.9.2!install version:1.0.9.2!requirement id:14436981!
| | | +-&freetype-py!version range:==2.3.0!install version:2.3.0!requirement id:14436982!
| | | +-&fs!version range:==2.4.16!install version:2.4.16!requirement id:14436983!
| | | +-&munkres!version range:==1.1.4!install version:1.1.4!requirement id:14436984!
| | | +-&pyobjc!version range:==8.5!install version:8.5!requirement id:14436985!
| | | +-&scipy!version range:==1.7.3!install version:1.7.3!requirement id:14436986!
| | | +-&skia-pathops!version range:==0.7.2!install version:0.7.2!requirement id:14436987!
| | | +-&ufolib2!version range:==0.13.1!install version:0.13.1!requirement id:14436988!
| | | +-&uharfbuzz!version range:==0.26.0!install version:0.26.0!requirement id:14436989!
| | | +-&unicodedata2!version range:==14.0.0!install version:14.0.0!requirement id:14436990!
| | | +-&zopfli!version range:==0.2.1!install version:0.2.1!requirement id:14436991!
| | +-&kiwisolver!version range:>=1.0.1!install version:1.4.4!requirement id:13319198!
| | +-&numpy!version range:>=1.17!install version:1.23.1!requirement id:13319199!
| | +-&packaging!version range:>=20.0!install version:21.3!requirement id:13319200!
| | | +-&pyparsing!version range:>=2.0.2!install version:3.0.9!requirement id:10632318!
| | +-&pillow!version range:>=6.2.0!install version:9.2.0!requirement id:13319201!
| | +-&pyparsing!version range:>=2.2.1!install version:3.0.9!requirement id:13319202!
| | +-&python-dateutil!version range:>=2.7!install version:2.8.2!requirement id:13319203!
| | | +-&six!version range:>=1.5!install version:1.16.0!requirement id:11782277!
| +-&multihist!version range:*!install version:0.6.5!requirement id:14710156!
| | +-&numpy!version range:*!install version:1.23.1!requirement id:8684278!
| +-&nestle!version range:*!install version:0.2.0!requirement id:14710157!
| +-&numba!version range:*!install version:0.56.0!requirement id:14710158!
| | +-&llvmlite!version range:<0.40,>=0.39.0dev0!install version:0.39.0!requirement id:14671231!
| | +-&numpy!version range:<1.23,>=1.18!install version:1.23.0rc3!requirement id:14671232!
| | +-&setuptools!version range:*!install version:63.2.0!requirement id:14671233!
| +-&numericalunits!version range:*!install version:1.25!requirement id:14710159!
| +-&numpy!version range:*!install version:1.23.1!requirement id:14710160!
| +-&pandas!version range:*!install version:1.4.3!requirement id:14710161!
| | +-&numpy!version range:>=1.18.5!install version:1.23.1!requirement id:14089551!
| | +-&python-dateutil!version range:>=2.8.1!install version:2.8.2!requirement id:14089552!
| | | +-&six!version range:>=1.5!install version:1.16.0!requirement id:11782277!
| | +-&pytz!version range:>=2020.1!install version:2022.1!requirement id:14089553!
| +-&pytest!version range:*!install version:7.1.2!requirement id:14710162!
| | +-&atomicwrites!version range:>=1.0!install version:1.4.1!requirement id:13914684!
| | +-&attrs!version range:>=19.2.0!install version:22.1.0!requirement id:13914685!
| | +-&colorama!version range:*!install version:0.4.5!requirement id:13914686!
| | +-&importlib-metadata!version range:>=0.12!install version:4.12.0!requirement id:13914687!
| | | +-&typing-extensions!version range:>=3.6.4!install version:4.3.0!requirement id:14116042!
| | | +-&zipp!version range:>=0.5!install version:3.8.1!requirement id:14116043!
| | +-&iniconfig!version range:*!install version:1.1.1!requirement id:13914688!
| | +-&packaging!version range:*!install version:21.3!requirement id:13914689!
| | | +-&pyparsing!version range:>=2.0.2!install version:3.0.9!requirement id:10632318!
| | +-&pluggy!version range:<2.0,>=0.12!install version:1.0.0!requirement id:13914690!
| | | +-&importlib-metadata!version range:>=0.12!install version:4.12.0!requirement id:13913869!
| | +-&py!version range:>=1.8.2!install version:1.11.0!requirement id:13914691!
| | +-&tomli!version range:>=1.0.0!install version:2.0.1!requirement id:13914692!
| +-&pytest-runner!version range:*!install version:6.0.0!requirement id:14710163!
| +-&scipy!version range:*!install version:1.9.0!requirement id:14710164!
| | +-&numpy!version range:<1.25.0,>=1.18.5!install version:1.23.1!requirement id:14719223!
| +-&seaborn!version range:<0.12,>=0.11.2!install version:0.11.2!requirement id:14710165!
| | +-&matplotlib!version range:>=2.2!install version:3.5.2!requirement id:8625985!
| | | +-&cycler!version range:>=0.10!install version:0.11.0!requirement id:13319196!
| | | +-&fonttools!version range:>=4.22.0!install version:4.34.4!requirement id:13319197!
| | | +-&kiwisolver!version range:>=1.0.1!install version:1.4.4!requirement id:13319198!
| | | +-&numpy!version range:>=1.17!install version:1.23.1!requirement id:13319199!
| | | +-&packaging!version range:>=20.0!install version:21.3!requirement id:13319200!
| | | +-&pillow!version range:>=6.2.0!install version:9.2.0!requirement id:13319201!
| | | +-&pyparsing!version range:>=2.2.1!install version:3.0.9!requirement id:13319202!
| | | +-&python-dateutil!version range:>=2.7!install version:2.8.2!requirement id:13319203!
| | +-&numpy!version range:>=1.15!install version:1.23.1!requirement id:8625987!
| | +-&pandas!version range:>=0.23!install version:1.4.3!requirement id:8625989!
| | | +-&numpy!version range:>=1.18.5!install version:1.23.1!requirement id:14089551!
| | | +-&python-dateutil!version range:>=2.8.1!install version:2.8.2!requirement id:14089552!
| | | +-&pytz!version range:>=2020.1!install version:2022.1!requirement id:14089553!
| | +-&scipy!version range:>=1.0!install version:1.9.0!requirement id:8625990!
| | | +-&numpy!version range:<1.25.0,>=1.18.5!install version:1.23.1!requirement id:14719223!
| +-&tqdm!version range:*!install version:4.64.0!requirement id:14710166!
| | +-&colorama!version range:*!install version:0.4.5!requirement id:13919205!
| | +-&importlib-resources!version range:*!install version:5.9.0!requirement id:13919206!
| +-&ultranest!version range:*!install version:3.4.6!requirement id:14710167!
| | +-&corner!version range:*!install version:2.2.1!requirement id:14521066!
| | | +-&matplotlib!version range:>=2.1!install version:3.5.2!requirement id:11138679!
| | +-&cython!version range:*!install version:0.29.32!requirement id:14521067!
| | +-&matplotlib!version range:*!install version:3.5.2!requirement id:14521068!
| | | +-&cycler!version range:>=0.10!install version:0.11.0!requirement id:13319196!
| | | +-&fonttools!version range:>=4.22.0!install version:4.34.4!requirement id:13319197!
| | | +-&kiwisolver!version range:>=1.0.1!install version:1.4.4!requirement id:13319198!
| | | +-&numpy!version range:>=1.17!install version:1.23.1!requirement id:13319199!
| | | +-&packaging!version range:>=20.0!install version:21.3!requirement id:13319200!
| | | +-&pillow!version range:>=6.2.0!install version:9.2.0!requirement id:13319201!
| | | +-&pyparsing!version range:>=2.2.1!install version:3.0.9!requirement id:13319202!
| | | +-&python-dateutil!version range:>=2.7!install version:2.8.2!requirement id:13319203!
| | +-&numpy!version range:*!install version:1.23.1!requirement id:14521069!

Suggested solutions

1.Change your direct dependency numpy [the latest version] to be numpy [<=1.23.0rc3].
2.Remove your direct dependency numpy [the latest version], and use numpy transitively introduced by numba.
3.Upgrade or downgrade your direct dependency numba to transitively introduce a compatible version of numpy.

Template morphing

With template morphing, we can get a great speed improvement of the code by interpolating between spectra (and also get more reliable results).

Increase coverage

The coverage is at ~60%, let's bring this up to a higher standard

Use classes for result

Construct a class for the result (either MCMC or nestle/multinest). This makes parsing much easier.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.