Would be great to have some testing instructions or similar in the readme to get started with the project. Perhaps there are people coming here who want to contribute.

Follow up todo from #90

Steps to reproduce the issue

Navigate to Content -> Media

Expected result

Media Manager

Actual result

<div id="filesview">
<br>
<b>Fatal error</b>
: Call to undefined function finfo_open() in
<b>C:\xampp\htdocs\media-manager-improvement\administrator\components\com_media\models\file\adapter\local.php</b>
on line
<b>446</b>
<br>
</div>

System information (as much as possible)

PHP Version 5.6.11
mysqlnd 5.0.11

clean php-codesniffer warnings in administrator/com_media

in php-storm run "code|inspect code" on each file

The current source of this project runs being the joola/joomla-cms project. Upstream needs to be added (git remote add upstream [email protected]:joomla/joomla-cms.git) and merged - this leads to various PHP Fatal Errors that need to be resolved.

https://github.com/joomla-projects/media-manager-improvement/wiki#categories

Implement basic categories for media

Introduce the nessecary associated database fields for media
parent_id
category_id

resolve @todo plugins/media-editor/imagecropper

Follow up todo from #90

currently all whitespaces are stripped, perhaps it is better to replace them with '-'

• The info sidebar is collapsable
• It shows basic information about the selected file or directory

Add a task bar for batch processing (move, etc)

https://github.com/joomla-projects/media-manager-improvement/wiki#categories

resolve @todo media/plg_media-editor_imagecropper

Follow up todo from #90

Probably just another example of my ignorance on the backend of this project however I am having the following issue within the Media Manager..

It appears the image filename within the a and img tags is including the entire local path rather than just the filename resulting in both been inaccessible..

<img width="60" height="13" alt="joomla_black.png - 4.86 kb" src="http://localhost/media-manager-improvement/images/C:\xampp\htdocs\media-manager-improvement\images\joomla_black.png">

<a class="img-preview" title="joomla_black.png" href="index.php?option=com_media&view=file&file=C:\xampp\htdocs\media-manager-improvement\images\joomla_black.png">

Steps to reproduce the issue

Open the Media Manager

System information (as much as possible)

Running on a localhost with the latest version of XAMPP
PHP Version: 5.6.24
Database Version: 5.5.5-10.1.16-MariaDB
Safe Mode: Off
Open basedir: None
Display Errors: On
Short Open Tags: Off
File Uploads: On
Magic Quotes: Off
Register Globals: Off
Output Buffering: On
Session Save Path: C:\xampp\tmp
Session Auto Start: 0
XML Enabled: Yes
Zlib Enabled: Yes

Update vue and vuex to the latest versions.

Steps to reproduce the issue

Make a get request with an invalid path

GET /administrator/index.php?option=com_media&format=json&task=api.files&path=some-invalid---or-not-existing-path

Expected result

Server responds with an 404 error.

Actual result

Server responds with an 200 error and empty data set

clean php-codesniffer warnings in plugins/media-editor/copy

in php-storm run "code|inspect code" on each file

Steps to reproduce the issue

Open create folder modal.
Fill in the folder name.
Hit enter key.

Expected result

New folder should be created
Modal should be closed

The edit form field needs to be changed to the new vue based list view. Should we go with the iframe approach or try to integrate vue into the edit forms like article.

Rename "Folders" to "Categories" within GUI text

https://github.com/joomla-projects/media-manager-improvement/wiki#categories

Steps to reproduce the issue

When I open the media manager in a subfolder, then I receive a 404 error. The paths to the api are absolute and should be relative. The same for the images in the folder contents view.

Hi

Will this new mediamanager allow us to upload a large image and create as many thumbnails we need with a JS croping interface ?

thanks

cyril

resolve @todo media/plg_media-editor_image_filters

resolve @todo administrator/components/com_media

clean php-codesniffer warnings in administrator/components/com_media

Follow up todo from #90

(it was just a quick fix for the resource response see #89)

clean php-codesniffer warnings in plugins/media-editor/imagecropper

in php-storm run "code|inspect code" on each file

clean php-codesniffer warnings in plugins/media-editor/rename

in php-storm run "code|inspect code" on each file

Follow up todo from #90

Steps to reproduce the issue

• Go to Joomla! 4 Administrator Control Panel
• Open media manager

Expected result

• Showing up directories and files in the media storage

Actual result

A message box showing up 200 OK and returning immediately to the control panel home page

System information (as much as possible)

PHP 7 with Windows

Additional comments

This is same as in the add article section, media manager won't come up when we want to add a image to an article.

clean php-codesniffer warnings in media/plg_media-editor_imagecropper

in php-storm run "code|inspect code" on each file

Load category information when loading folder model. Create category otherwise.

https://github.com/joomla-projects/media-manager-improvement/wiki#categories

Steps to reproduce the issue

Try to create a new folder:
POST /administrator/index.php?option=com_media&format=json&task=api.files&path=/
JSON BODY: {name: 'my-folder'}

Expected result

A single resource response (not an array of items) with the data of the newly created folder:

{
  success: true,
  message: null, 
  messages: null, 
  data: {
    type: "folder", 
    name: "my-folder", 
    path: "/my-folder", 
    extension: "", 
    size:…
  }
}

Actual result

The contents of the newly created folder.

{success: true, message: null, messages: null, data: []}

clean php-codesniffer warnings in media/plg_media-editor_image_filters

in php-storm run "code|inspect code" on each file

As pr #116 revealed. We need to address how error and exception handling should be done in the new media manager. Only on client side or server side and client side or only server side. We need to define a procedure for the following errors:

• PHP errors
• Exceptions
• Invalid data
• Javascript errors

resolve @todo plugins/media-editor/copy

Create a new library under libraries/vendor/joomla-projects and have it include a Joomla\MediaManager\Image\ActionInterface interface.

Create a menu with "Images" and "Categories"

https://github.com/joomla-projects/media-manager-improvement/wiki#categories

For samples see https://github.com/joomla-projects/media-manager-improvement/wiki/Image_Transformations

Copy sample from wiki (https://github.com/joomla-projects/media-manager-improvement/wiki/Image_Transformations) to libraries/

resolve @todo plugins/media-editor/rename

• Run the bundling command with NODE_ENV set to "production". This tells vueify to avoid including hot-reload and development related code.

• Apply a global envify transform to the bundle. This allows the minifier to strip out all the warnings in Vue’s source code wrapped in env variable conditional blocks.

• Exclude the resource and build files from the joomla build process.

• Extract inline styles to separate css file: NODE_ENV=production browserify -g envify -p [ vueify/plugins/extract-css -o media-manager.css ] -e app.js | uglifyjs -c -m > app.js

A new api controller should be introduced which acts as endpoint for the client side javascript code.

clean php-codesniffer warnings in plugins/media-editor/imagefilters

in php-storm run "code|inspect code" on each file

• Use the default joomla language files

Vue Plugins:

• https://github.com/kazupon/vue-i18n

resolve @todo plugins/media-editor/imagefilters

resolve @todo administrator/com_media

• Validate / Sanitize input
• Return the correct status / messages codes on errors