Git Product home page Git Product logo

install-from-web-client's Introduction

Archived

This plugin moved into the Joomla! core, please report bugs directly at https://github.com/joomla/joomla-cms

Install from Web Client

Home of the "Install from Web" (aka Joomla Extension Finder) plugin for the Joomla! CMS.

install-from-web-client's People

Contributors

andrepereiradasilva avatar beat avatar coolbung avatar dgrammatiko avatar hleithner avatar mbabker avatar nicksavov avatar philetaylor avatar wilsonge avatar zero-24 avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

install-from-web-client's Issues

Option Last Tab Request

Hello, Install from web had in previous versions an option to place it as last item and currently it is not available. Is it possible to bring in back to the scene please?

The reason is that once we are on the install menu the web tab takes some time to load and is actually annoying while of course it is a really good to have as an option but not something that is used everyday.

Kind Regards.

Untranslated strings

I noticed in the javascript that there are multiple strings that are not translated - sorry dont know how to fix that

var redirect_confirm = confirm('You will be redirected to the following link to complete the registration/purchase - \n'+redirect_url);

alert("This extension cannot be installed via the web. Please visit the developer's website to purchase/download.");

Removing install-from-web-server dependency

Now that we have a chance to refactor the IFW, I propose that we get rid of the IFW server. The new JED has JSON APIs that we can directly use to create the views. I'm hoping that we can reuse the existing jlayouts and convert them into jquery templates (https://github.com/codepb/jquery-template/) in order to have the same look and feel to start with.

Let me know if you guys see any issues with this approach.

Loading .... issue [after installing an extension]

This is still a problem, majority of loading issues are fixed with the last release/pr #35 but there remains an issue when Install From Web is the first tab, and immediately after installing an extension, thepage loads with the success text for that, but the Install from web tab pane is blank (although the code triggers the load)

First / Last tab

The param works to move the tab from first to last BUT when in the first position it is never the default option. Not sure if this was by design or not.

s7ns

Server timeout when no connection (Direct JED)

With the new prototype plugin, the whole installer gives an error when the plugin fails to connect to extensions.joomla.org. This may happen when JED is down or when you're behing a Firewall that blocks access.
timeout

Disabling the plugin obviously solves it, but it's not a good solution for cases when JED is down.

Uninstalling new plugin leaves the JLayouts (Direct JED)

When uninstalling the new plugin, the files in layout/joomla/installer/web are not removed.
This is because they are copied over by the install script and we don't have a way to install layouts into the global layouts folder.
It should however somehow be possible to use the layouts folder within the extension.

Back to Category Warning class

The Back to Category button has a class btn-warning giving it a colour of #e48806

Doesnt make sense to me and is not consistent with the rest of Joomla it should be btn-primary which is blue

Pagination

There is no option to change the number of items displayed on a page. This is inconsistent with the rest of Joomla

Can not upgrade Installer - Install from Web 1.1.1 to 2.0.1 on Joomla 3.9.5.

I can not upgrade "Installer - Install from Web" from 1.1.1 to 2.0.1, not from direct online update nor from uploaded zip file.

Here is my environment:

  • PHP 7.2.17.
  • Joomla 3.9.5.

here is error message
Warning

Copy failed: /home/[user]/public_html/web/joomla/tmp/install_5cb3ee1cc3a65/webinstaller.php to /home/[user]/public_html/web/joomla/plugins/installer/webinstaller/webinstaller.php
JInstaller: :Install: Failed to copy file /home/[user]/public_html/web/joomla/tmp/install_5cb3ee1cc3a65/webinstaller.php to /home/[user]/public_html/web/joomla/plugins/installer/webinstaller/webinstaller.php
Plugin Update: Could not copy files from the source.
Before updating ensure that the update is compatible with your Joomla! installation. 
You are strongly advised to make a backup of your installation before you start updating.

My root Joomla is /home/[user]/public_html/web/joomla/.

I set all permission folder and file to writable, but it does not solved the problem.

Cross-Origin Read Blocking warning with at least Chrome 73 & Firefox 66

Error trace similar to this:

Cross-Origin Read Blocking (CORB) blocked cross-origin response https://appscdn.joomla.org/webapps/index.php?format=json&option=com_apps&view=dashboard&product=Sm9vbWxhIQ==&release=My45&dev_level=NA==&list=grid&pv=Mi4wLjA= with MIME type application/json. See https://www.chromestatus.com/feature/5629709824032768 for more details.
send @ jquery.min.js?c8aac89f3316b44667cff50199517fb5:2
ajax @ jquery.min.js?c8aac89f3316b44667cff50199517fb5:2
Joomla.loadweb @ client.min.js?c8aac89f3316b44667cff50199517fb5:1
Joomla.apps.initialize @ client.min.js?c8aac89f3316b44667cff50199517fb5:1
(anonymous) @ index.php?option=com_installer:441
dispatch @ jquery.min.js?c8aac89f3316b44667cff50199517fb5:2
v.handle @ jquery.min.js?c8aac89f3316b44667cff50199517fb5:2
jquery.min.js?c8aac89f3316b44667cff50199517fb5:2

https://www.chromestatus.com/feature/5629709824032768
https://www.chromium.org/Home/chromium-security/extension-content-script-fetches

Install the install from web fails to load on page load

Install from github joomla-cms master at revision 351b778254893d1ebbd734a88e3ad2a33b386aff

Login to admin

Install the install from web with the button provided

see that it fails to load the content all the time

screen shot 2016-12-11 at 15 28 57

To make it load this correctly you can click another tab and then click the Install from web tab

screen shot 2016-12-11 at 15 32 04

Cross posted to joomla/joomla-cms#13165

Install From Web plugin 2.0.1 fails

The newest "Install From Web plugin v 2.0.1" fails

  • J3.9.14,
  • Firefox 73.0b1 (latest).
  • Error message in browser: Can't connect to the Joomla! server. Please try again later.
  • Console error message:
Loading failed for the <script> with source “https://appscdn.joomla.org/webapps/index.php?format=json&opt…el=MTQ=&list=grid&pv=Mi4wLjE=&callback=jedapps_jsonpcallback”. index.php:1:1

Add "Install from Web" option not enabling

Expected result

An install from web options in tab at extension install page
Actual result

Refer the screen shot
Additional comments

I tried doing this many times, still the same result
web

Please freeze the page when the animated gif is displayed

Whenever the joomla logo is displayed an overlay is also rendered BUT the page can still be scrolled

The effect is painful for the eyes.

Suggestion

Add a css style

body.modal-open {
    overflow: hidden;
    -ms-overflow-style: none;
} 

And these two lines of javascript in the relevant places e.g. init ajax, onSuccess

$('body').addClass('modal-open');
$('body').removeClass('modal-open');

This will freeze the page and will be much better

Just as a reminder this code comes from joomla/joomla-cms#6964
which is RTC and most probably will make it to 3.4.2 so maybe the css styling won’t be necessary

Thanks

Remove the "First/Last" parameter

With J3.6 the installer is built with a plugin for each tab, similar to the install from web plugin.
The position of each tab is determined by the ordering of the plugins.

This makes the position parameter in the ifw plugin obsolete and actually limits the functionality.
Thus that parameter should be removed.

Search function in install from web does not return correct results

Steps to reproduce the issue

Try searching for an extension by name in the web installed tab. I searched for "JCE" , "Joomla content editor", "simple image gallery" etc. I've attached some screenshots after search was done:

screen shot 2016-08-17 at 10 19 18 am
screen shot 2016-08-17 at 10 18 58 am
screen shot 2016-08-17 at 10 18 14 am

Expected result

The record which has the closest match should end up on top, eg. JCE Editors' listings as well as JCE related plugins, or something that at least contains the string.

Actual result

Heaps of non related extensions, with no mention of the original search string in the results.

System information (as much as possible)

Vanilla install of Joomla 3.x. As far as I can remember, this is an issue with all the Joomla versions that has the web installer.

Additional comments

I don't have a solution or PR for this yet, but want to get into the code and see if I can improve the search so that it actually works.

I don't know how many people use the feature, but it has frustrated me so much in the past, especially when setting up a new site, that I just went and downloaded the extensions direct form the developer sites and did not bother to use the web installer.

Notice: Trying to access array offset on value of type null - when re-installing client

Joomla 3.9.19 on Wampserver 3.2.2: Apache 2.4.43a - MySQL 8.0.20 - PHP 7.4.7

Click the button 'Add "Install from Web" tab'.
Download client from https://downloads.joomla.org/us/extensions/install-from-web/2-0-1 and install it.

Result:
Notice: Trying to access array offset on value of type null in C:\www\joomla39\libraries\src\Installer\InstallerScript.php on line 144

Trace:

Time Memory Function Location

1 0.0003 368912 {main}( ) ...\index.php:0
2 0.0866 1147920 Joomla\CMS\Application\AdministratorApplication->execute( ) ...\index.php:51
3 0.0866 1147920 Joomla\CMS\Application\AdministratorApplication->doExecute( ) ...\CMSApplication.php:196
4 0.1129 1747368 Joomla\CMS\Application\AdministratorApplication->dispatch( ) ...\AdministratorApplication.php:159
5 0.1187 1771112 Joomla\CMS\Component\ComponentHelper::renderComponent( ) ...\AdministratorApplication.php:101
6 0.1197 1898144 Joomla\CMS\Component\ComponentHelper::executeComponent( ) ...\ComponentHelper.php:377
7 0.1198 1915072 require_once( 'C:\www\joomla39\administrator\components\com_installer\installer.php' ) ...\ComponentHelper.php:402
8 0.1300 2000464 InstallerControllerInstall->execute( ) ...\installer.php:19
9 0.1300 2000464 InstallerControllerInstall->install( ) ...\BaseController.php:710
10 0.1325 2010576 InstallerModelInstall->install( ) ...\install.php:35
11 0.3148 2065240 Joomla\CMS\Installer\Installer->install( ) ...\install.php:187
12 0.3288 2192808 Joomla\CMS\Installer\Adapter\PluginAdapter->install( ) ...\Installer.php:521
13 0.3320 2226144 Joomla\CMS\Installer\Adapter\PluginAdapter->triggerManifestScript( ) ...\InstallerAdapter.php:712
14 0.3320 2242656 plginstallerwebinstallerInstallerScript->preflight( ) ...\InstallerAdapter.php:1026
15 0.3320 2242656 plginstallerwebinstallerInstallerScript->preflight( ) ...\webinstaller.script.php:140

Install From Web Search

Steps to reproduce the issue
In the admin side of Joomla, go to Extensions >> Install
On the Install from Web tab, click into the search field and type 'VirtueMart' (without quotes)
Click the magnifying glass search button
Look for "VirtueMart" within the search results.

Expected result
The Name of the extension should be weighted first and therefore the extension "VirtueMart" should have been first before any other extensions with "VirtueMart" in the description. Not sure why "Breezing Forms" keeps popping up first. Sort dropdown box should be defaulted to "Sort be Relevance"

Actual result
The "VirtueMart" Extension is not listed, "Breezing Forms" is the first one listed which is not even close to "VirtueMart".

I even tried to go into the e-Commerce category and search from there but it jumped to the "Home" category and guess what? ... "Breezing Forms" is at the top.

System information (as much as possible)
Joomla 3.4.8

Back to Category

When you select the detailed view of any extension there is a button labelled "Back to Category"
That makes sense when you have reached that extension from a category but not from the home age which is "most popular" and not a category
I would suggest simply changing that to say "Back"

Image size

Not sure if anything can be done about this but the page load of a category is very slow. This is because the images being grabbed are Huge and with so many on the page it makes it very slow to load even on a good connection.

For example for Akeeba Abckup the image being loaded is
548ff93e7bdd0.png and is 97kb

We should be using the smaller image available for Akeeba Backup which is
548ff93e7bdd0_resizeDown302px133px16.png and only 27kb

Maybe the JED stores/creates even smaller images for use

Language strings issues

Missing string in core:
COM_INSTALLER_WEBINSTALLER_INSTALL_RETRY

Also
COM_INSTALLER_WEBINSTALLER_INSTALL_WEB_LOADING_ERROR="Cannot connect to the Joomla! server. Please try again later."
has no variable and is used in a sprintf

<a class="close" data-dismiss="alert">×</a><?php echo JText::sprintf('COM_INSTALLER_WEBINSTALLER_INSTALL_WEB_LOADING_ERROR', $retry); ?>

Missing strings

PLG_INSTALLER_WEBINSTALLER_TAB_TIMEOUT_LABEL
PLG_INSTALLER_WEBINSTALLER_TAB_TIMEOUT_DESC
PLG_INSTALLER_WEBINSTALLER_ITEMS_PER_REQUEST_LABEL
PLG_INSTALLER_WEBINSTALLER_ITEMS_PER_REQUEST_DESC

Default

In the path we have a first level called Default (returns you to the Most Popular)
To me the word Default implies that there is an option somewhere that can be changed - there isn't
So I would suggest simply changing it to Home

Extension images dissapeard after JED update

Hello,

I just noticed that, after the JED update, the images of the extensions are not correct loaded. The link to the images ends in a 404 not found.

Also a merry Christmas to everyone!

Greeting,
Niels

Sort Order

The Sort options are all hard coded to only sort in one direction - ok I guess
But I doubt anyone would ever want to Sort by Reviews or Sort by Scored starting with the ones with ZERO

I would suggest EITHER changing that to sort by the highest number OR adding Sort by * Ascending and Sort by Descending

For Next Release

  1. SSL fix is already committed. #2 can be closed once a package is created and a message is left in #2 to test.

  2. #8 is done. It can be closed.

  3. #10 is done in the serverside. It can be closed.

  4. Merge #6

  5. Merge #7 - Check #23 instead

  6. Merge #15

  7. Merge #20 - Merged

  8. Remove 2.5 support: #18 - Merged

  9. Create a test package.

Prepare for Downloads Site Support

In the next few days we will turn on the Extensions section of the downloads site which will include Weblinks and Install from Web. To support this, the update server definition should be ready to use the site when we enable the new section. This will require the following updates:

http://appsserver.joomla.org/webapps/jedapps/downloads/plugin/plg_webinstaller_3.2v1.0.5.zip will be served via https://downloads.joomla.org/extensions/install-from-web/1-0-5/plg_webinstaller_3.2v1.0.5.zip

http://appsserver.joomla.org/webapps/jedapps/downloads/plugin/plg_webinstaller_3.7v1.1.1.zip will be served via https://downloads.joomla.org/extensions/install-from-web/1-1-1/plg_webinstaller_3.7v1.1.1.zip

@beat I will ping again when we launch the section, if you could please be ready to update the XML file that'd be greatly appreciated.

Popular Extensions - home page

This is NOT popular extensions it is ALL extensions sorted by score (unless a different sort has been chosen) - there are 972 pages

I would suggest either renaming this to "ALL" or limiting the number of extensions fetched to be a true popular list.

Right now a user could select popular an then change the sort by reviews and think they are seeing something that they are not

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.