Git Product home page Git Product logo

bottomsheet's People

Contributors

mikhailmaslo avatar pboulch avatar rusik avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar

bottomsheet's Issues

Cannot receive the dismissCompletion event

hello ,i am facing a issues that if i using dismiss(animated: true) instead of swipe-down or just tapping on an empty space, the dismissCompletion cannot be received ,how to solve it , thanks you

Swipe the botomsheet presented on botomsheet

I found a strange behaviour, that if botomsheet is presented on botomsheet and we swipe the top one down, both will be dismissed. But if we tap on shadow or call dismiss of top one by ourselves, everything will be alright.

I guess the reason is this method of BottomSheetPresentationController:
image

The tap works with such a way:
image

Looks like in startInteractiveTransition the presenting controller dismisses, so the both bottomsheets dismisses. Can you please change the behavier to dismiss only presented bottomshet? All my tries failed 😞

Cannot find option to disable dismiss

presentBottomSheet(
viewController: viewControllerToPresent,
configuration: BottomSheetConfiguration(
cornerRadius: 10,
pullBarConfiguration: .visible(.init(height: 20)),
shadowConfiguration: .init(backgroundColor: UIColor.black.withAlphaComponent(0.6))
),
canBeDismissed: {
// return true or false based on your business logic
true
},
dismissCompletion: {
// handle dismiss completion if user closed bottom sheet by a gesture
}
)
I can't find above function which allows me to pass canBeDismissed. Can anyone help me

didSelectRowAt indexPath: IndexPath

Столкнулся с проблемой вызова метода didSelectRowAt табличного представления, ячейка подсвечивается цветом, но события не приходит в метод didSelectRowAt

возможно где то не выставлено свойство жеста cancelsTouchesInView = false

Apple's update to their API policy - Required Reason in Privacy manifest

Describe the feature or problem you’d like to solve

From Fall 2023 Apple starts rolling out new privacy requirements, The apps and third-party SDKs should contain a privacy manifest file when they access required reason API. SkeletonView SDK uses UserDefaults which is required description of use in PrivacyManifest.
Otherwise, apps that don’t describe their use of required reason API in their privacy manifest file won’t be accepted by App Store Connect. Here is a link to the [Apple documentation].(https://developer.apple.com/documentation/bundleresources/privacy_manifest_files/describing_use_of_required_reason_api).

Proposed solution

Add a PrivacyInfo.xcprivacy file and the following information to the Privacy Accessed API Types section
Privacy Accessed API Type: User Defaults
Privacy Accessed API Reasons: CA92.1: Access info from same app, per documentation

Additional context

Apple documentation

BottomSheet does not contain bitcode

Hello,

I have a problem when try create archive in Xcode 14,
Showing Recent Issues ***/BottomSheet.o' does not contain bitcode. You must rebuild it with bitcode enabled (Xcode setting ENABLE_BITCODE), obtain an updated library from the vendor, or disable bitcode for this target. file ***/BottomSheet.o' for architecture arm64

More customisation options

I want to know if we do have a more configuration options like blur intensity, dismiss pan and tap gesture? Currently I think pan gesture needs to work with few methods but I think we can do it by single boolean value.

BottomSheet is presented over TabBar

Hello,

I am currently using your library for a project and I'm encountering an issue where the BottomSheet is presented over the TabBar. I would like the TabBar to remain visible when the BottomSheet is presented.

Here is the code I'm using to present the BottomSheet:

    viewController: ModalviewController,
    configuration: BottomSheetConfiguration(
        cornerRadius: 10,
        pullBarConfiguration: .visible(.init(height: 20)),
        shadowConfiguration: .init(backgroundColor: UIColor.black.withAlphaComponent(0.6))
    ),
    canBeDismissed: {
        true
    },
    dismissCompletion: {
    }
)

I've tried presenting the BottomSheet from the TabBarController itself, but this did not solve the issue. Here's the code for that attempt:

    viewController: ModalviewController,
    configuration: BottomSheetConfiguration(
        cornerRadius: 10,
        pullBarConfiguration: .visible(.init(height: 20)),
        shadowConfiguration: .init(backgroundColor: UIColor.black.withAlphaComponent(0.6))
    ),
    canBeDismissed: {
        true
    },
    dismissCompletion: {
    }
)

Is there a solution or workaround for this problem? Any guidance would be much appreciated.

RootView access

Is it possible to make root view controller available when bottom sheet is opened. Like in the Apple Maps app? The sheet is open but you can scroll the map behind it.

Presentation of multiple bottom sheets

I am facing issues with the presentation of multiple bottom sheets, particularly when one is triggered before the other has finished its presentation,

One of scenarios as an example:
LoadingBottomSheet is presented.
An error response is received from server and ErrorBottomSheet should be presented.
So, Loading dismiss is called and it gets dismissed but the EroorBottomSheet is not presented because:
Attempt to present <ErrorBottomSheet: 0x113e1e2e0> while a presentation is in progress.

Is there a solution for this in the current version like creating a queue when calling present or not?

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.