jookies / smpp.pdu Goto Github PK

There is mapping error in PriorityFlag Enumeration , PriorityFlag enumeration value mappings are starting from 1.

Due to this issue , if we choose priority value 3 in jasmin sms request, the value receive will be 4 and thus it's failing the validation and causing the below exception.

Traceback (most recent call last):, File "/usr/local/lib/python3.9/site-packages/jasmin/protocols/smpp/factory.py", line 333, in submit_sm_event_interceptor, return self.submit_sm_post_interception(routable=routable, system_id=system_id, proto=proto), File "/usr/local/lib/python3.9/site-packages/jasmin/protocols/smpp/factory.py", line 474, in submit_sm_post_interception, c = self.SMPPClientManagerPB.perspective_submit_sm(, File "/usr/local/lib/python3.9/site-packages/twisted/internet/defer.py", line 1613, in unwindGenerator, return _cancellableInlineCallbacks(gen), File "/usr/local/lib/python3.9/site-packages/twisted/internet/defer.py", line 1529, in _cancellableInlineCallbacks, _inlineCallbacks(None, g, status), --- <exception caught here> ---, File "/usr/local/lib/python3.9/site-packages/twisted/internet/defer.py", line 1418, in _inlineCallbacks, result = g.send(result), File "/usr/local/lib/python3.9/site-packages/jasmin/managers/clients.py", line 581, in perspective_submit_sm, c = SubmitSmContent(, File "/usr/local/lib/python3.9/site-packages/jasmin/managers/content.py", line 154, in __init__, raise InvalidParameterError("Priority must be set from 0 to 3, it is actually set to %s" %, jasmin.managers.content.InvalidParameterError: Priority must be set from 0 to 3, it is actually set to 4,

This issue can be fixed by replacing the pdu_types module code

PriorityFlag = Enum('PriorityFlag', list(constants.priority_flag_name_map.keys()))

with;

PriorityFlag = Enum('PriorityFlag', list(constants.priority_flag_name_map.keys()),start=0)

I've tried creating a pull request but seems like no permission to do that .

Please make this changes to avoid this error .

Thanks.