jonwilsdon / ion-binary-explorer Goto Github PK

The symbol count is being captured and there is a symbol count column in the symbol tables but it is not being populated.

When you scroll on one tab and switch to another tab, the scroll position is shared between the tabs. The scroll position should be independent between the tabs.

The previous elements on the binary tab are not cleared and hidden when jumping to an offset which can lead to the previous elements displaying after the current elements if there were previous elements at a later offset than what is displayed with the current elements.

Testing should include integrating the binary files from https://github.com/amzn/ion-tests.

When there are a lot of symbols loading on the symbol table tab the whole page freezes. The symbol tables should be loaded incrementally when viewed and not all at once.

When using jump to offset, the target offset is not highlighted or expanded. The scroll position is also not adjusted to bring the offset into the viewable area.

When loading a non-binary Ion file there is an error thrown in the console, but there is no error visible to the user.

The code that is currently running the Ion Binary Explorer on the gh-pages branch is not in the main branch of this repository. Copy it to this repository, and clean it up in a series of pull requests.

PRs:

• IonTypes, TypeDescriptorReader, ByteBufferReader (#10)
• ElementReference, IonElement, ScalarValueReader (#12)
• SymbolTable, Verifier?
• worker-coordinator, top-level-worker?
• reader-worker, inspect-worker, Inspector, StructuralAnalyzer?

When the binary tab is displaying an offset that does not start on a top level value, the implicit container ends do not display.