jonschwadron / project-tictactoe Goto Github PK

This is a pretty decent start. My only big complaint, is that it's messy. I would suggest cleaning this up before you show it to a prospective employer. Here are some thoughts about the code:

1. Remove your firebase.html, js, and css if you don't need them. Do the same for params.json.
2. Good job separating your files into css/js directories. Some people didn't do this, and it really helps in production to keep things organized.
3. HTML classes don't need to have a . in them. You only use a . in your css and javascript
4. There is a lot of code you don't need, keep it simple just what you want for the task. Things for viewport and IE don't matter right now.
5. Your commenting is a little sparse. I usually suggest putting in a comment for every action that takes place in your code. In production, this will let other devs (and your future self) know what you were thinking when you wrote the code.
6. You have a lot of global functions. If you can, put them in an object, so that's well organized and doesn't pollute the global namespace

If you have any questions about these suggestions or something else that you couldn't figure out, feel free to hit me up, and we can chat about it.