Git Product home page Git Product logo

Comments (2)

JonnyJD avatar JonnyJD commented on June 27, 2024

Well, a part of the question is:
Can the first track be something different than 1?

The standard says "The track numbering shall start with the value 01 and increment by one."
So the first track number is extracted from disc, but it should be 1 for every standard CD and musicbrainz DOES have problems when the first track wouldn't be 1. (I read a bit in the code).
This is one of the reasons why the first track is not discarded, even if it is a data track.

http://musicbrainz.org/release/046d66a3-ec8f-4d24-873f-21a11f67b0fb is the Quake game disc. First track is a data track (the game) the other 10 tracks are audio tracks.
The first track reported by the driver is still track number 1.

I'll yet have to see (even on the net) a single audio disc where the first track is not 1.

So that shouldn't be an issue.
I might however correct the code so it would technically fill the tracks before the first track. Just in case.

from python-discid.

JonnyJD avatar JonnyJD commented on June 27, 2024

One thing is a bit weird with my implementation:

for track in tracks:

directly doesn't work, since you don't want to list track 0 normally.

You are suppose to do:

for i in range(1, disc.last_track_num + 1):

from python-discid.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.