Git Product home page Git Product logo

Comments (4)

JonnyJD avatar JonnyJD commented on September 24, 2024

The error message in python setup.py test -vv is:

FAIL: test_default_device (test_discid.TestModule)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/Users/jonnyjd/git/python-discid/test_discid.py", line 32, in test_default_device
    self.assertTrue(device, "No default device given")
AssertionError: No default device given

from python-discid.

JonnyJD avatar JonnyJD commented on September 24, 2024

Maybe we should even remove that test altogether, since it doesn't test much.
It only tests that a default device is available and that obviously fails on any platform that doesn't implement this.
It is part of the "platform dependent" API.

So we should test this only on the platforms where it is supported, which is something python-discid shouldn't be bothered with.

-> Remove that test altogether

We might want to include that in a "platform test" suite. That suite should be excluded on python setup.py test, though.

from python-discid.

JonnyJD avatar JonnyJD commented on September 24, 2024

Platform dependent test implementation is handled in #18

We might just comment that part out in some way for now or start imlementing #18 a bit already.

from python-discid.

JonnyJD avatar JonnyJD commented on September 24, 2024

http://tickets.musicbrainz.org/browse/LIB-28 is relevant here.
That is basically about adding support for numbers as drives on Mac and using "1" as the (static) default.

However, there will always be the old libdiscid versions (starting with libdiscid 0.2.1) that have the "dynamic" behavior.

from python-discid.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.