Comments (4)
The error message in python setup.py test -vv
is:
FAIL: test_default_device (test_discid.TestModule)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/Users/jonnyjd/git/python-discid/test_discid.py", line 32, in test_default_device
self.assertTrue(device, "No default device given")
AssertionError: No default device given
from python-discid.
Maybe we should even remove that test altogether, since it doesn't test much.
It only tests that a default device is available and that obviously fails on any platform that doesn't implement this.
It is part of the "platform dependent" API.
So we should test this only on the platforms where it is supported, which is something python-discid shouldn't be bothered with.
-> Remove that test altogether
We might want to include that in a "platform test" suite. That suite should be excluded on python setup.py test
, though.
from python-discid.
Platform dependent test implementation is handled in #18
We might just comment that part out in some way for now or start imlementing #18 a bit already.
from python-discid.
http://tickets.musicbrainz.org/browse/LIB-28 is relevant here.
That is basically about adding support for numbers as drives on Mac and using "1" as the (static) default.
However, there will always be the old libdiscid versions (starting with libdiscid 0.2.1) that have the "dynamic" behavior.
from python-discid.
Related Issues (20)
- Find libdiscid in current folder for linux/unix HOT 2
- Prefer libdiscid in current directory HOT 1
- disc access test suite
- consider using `discid_read_sparse` when/if implemented in libdiscid HOT 2
- Uninformative error on Windows when libdiscid is not found HOT 1
- reconsider track_offsets[0], track_lengths[0] etc. HOT 2
- Don't expose discid_get_webservice_url HOT 2
- Don't make DEFAULT_DEVICE a constant HOT 2
- add get_devices() function? HOT 3
- leaks many file descriptors HOT 1
- Ask user to re-enter user/password on authentication errors HOT 1
- py2app dmg/dylib problems again HOT 4
- On Windows system wide discid.dll seems to be preferred over local version HOT 5
- Doc fails to build with sphinx 1.3 HOT 1
- Split up DiscError HOT 1
- macOS: Prefer libdiscid.dylib in current folder HOT 2
- Add gpg key HOT 1
- tests relying on /dev/cdrom failing when running with pytest
- Invalid TOC seemingly generated (MBS-10050)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from python-discid.