BUG: `pick_connection` returns incorrect values when applied to network with no cell-cell connections about hnn-core HOT 3 CLOSED

hnn-core/hnn_core/network.py

Lines 282 to 294 in 54ddd40

	for search_terms, search_dict in search_pairs:
	inner_set = set()
	# Union of indices which match inputs for single parameter
	for term in search_terms:
	inner_set = inner_set.union(search_dict.get(term, list()))
	# Intersection across parameters
	if conn_set and inner_set:
	conn_set = conn_set.intersection(inner_set)
	# If at any point there's no matching elements, return empty
	if not conn_set:
	return list()
	else:
	conn_set = conn_set.union(inner_set)

Tracing the issue... I think lines 291-292 are nested too far in? That if statement can't ever trigger since it's nested in an a conditional where it must be True.

Nevermind I'm incorrect. The intersect can change the set to none. I have a different solution.

from hnn-core.

Tracing the issue... I think lines 291-292 are nested too far in? That if statement can't ever trigger since it's nested in an a conditional where it must be True.

from hnn-core.

Fix with an accompanying unit test welcome !

from hnn-core.