`plot_cells` error when users pass in a generic matplotlib.Axes instance about hnn-core HOT 8 CLOSED

Hey @rythorpe , can I take this issue, Can you confirm that we just need to check if ax is not an instance of Axes3D and then raise a TypeError?

from hnn-core.

Yep, go for it @samadpls!

from hnn-core.

Fix is welcome !

from hnn-core.

I don't think there is a way to update an 2d axis to a 3d projection. https://stackoverflow.com/questions/35209489/can-i-turn-an-existing-ax-object-into-a-3d-projection

Maybe there should be a check on an axes argument and raises an error if it's not a Axes3D object?

from hnn-core.

I was thinking of removing the existing 2D axes and then adding new 3D axes, but this might mess with formatting if the user starts with a more detailed grid of subplots (maybe?). Your suggestion about adding a check for an Axes3D object is probably the easiest solution, however.

from hnn-core.

In that case I think the user would have to pass the grid/subplot/figure so you can index which one to replace. I don't think it's typical convention to pass the whole axes array to a plotting function.

from hnn-core.

I believe the figure as accessible via Axes.get_figure(), but I generally agree that the simpler solution where we raise an error if the user attempts plotting on the wrong type of Axes object is the way to go.

from hnn-core.

as long as we catch the error before it becomes a cryptic traceback, I think it's fine

from hnn-core.