Calcium dynamics about hnn-core HOT 4 CLOSED

@SMPugliese thanks for opening the issue! Did you close it intentionally? I'm reopening it to discuss further. Can you edit your comment above to add a link to your repository?

I had created a pull request with the files that Carmen sent me here. Obviously this is not everything you have done. In general, I think it's a good idea to contribute back to the HNN repository. That way, you can have your changes up to date with everything else in HNN and you are not working off an older version. It's also a good opportunity to test whatever you change.

One obvious way I see to incorporate your change is to allow a L5pyr argument in the Network class that is None by default. This way you can override the default L5Pyr class with one you provide. Something like:

from hnn_core.pyramidal import L5Pyr

class L5PyrCustom(L5Pyr):

    def __init__(self, gid, pos, p):
        L5Pyr.__init__(gid, pos, p)

    def _biophys_dends(self):
        # your modified code here

net = Network(...., L5Pyr=L5PyrCustom)
dpl = simulate_dipole(net)

from hnn-core.

Thanks! I've edited to include the link. I can submit a pull request to this repository later as well.

from hnn-core.

sounds good, start something and we'll help you if you get stuck!

from hnn-core.

closed by #333

from hnn-core.