joncodo / crib Goto Github PK

I'm experimenting with making each review point a separate comment...

Individual recommendations in comments on this ticket.

Each suggestion is in a comment below...

Suggestions in comments...

I haven't played cribbage in a while, so take my comments lightly.

I would get rid of the before(:each) block and just create the cards as needed. Because you're creating cards you aren't using in your tests.

I think describe Card, '#value' can be describe '#value' since it's already within the describe Card block.

Change the spec-name 'is has the number value...' to 'is the rank value...'

This will allow you to use rake to automate testing and code coverage.

I suggesting adding a test and coverage task.

rake test # run all tests
rake coverage # generate a code coverage report using simplecov

Example Rakefile snippet:

desc 'Generate coverage report'
task :coverage do
  ENV['COVERAGE'] = 'true'
  system('rake test')
end

Reason: these files have to do more with your programming environment than the problem domain.

Remove the .idea and .DS_Store files from source control, and add a .gitignore
file with the following entries

.idea
.DS_store

Reason: to_s is ruby's idiomatic way of representing a class as a string.

Get rid of the display_value field, and add a to_s method that does the same thing.

def to_s
  "#{number}-#{suit}"
end