Git Product home page Git Product logo

ultimate-react-course's People

Contributors

jonasschmedtmann avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

ultimate-react-course's Issues

cloneElement in the modal is broken

Using cloneElement in the modal Open component causes a bug unexpectedly

return cloneElement(children, { onClick: () => open(opens) });

This code works
<```
Modal.Open opens="delete">
Delete Booking </Modal.Open>


**This below code doesnt not work,**

<Modal.Open opens="delete">
{status === "checked-out" && (
Delete Booking
)}
</Modal.Open>


**I get this error**
> Uncaught Error: Element type is invalid: expected a string (for built-in components) or a class/function (for composite components) but got: undefined. You likely forgot to export your component from the file it's defined in, or you might have mixed up default and named imports

However it had been working before I added the **ErrorBoundary library**

React Quiz App

The api request with questions in the Quiz app seems to be corrupted.

Incorrect Variable Mapping in Data Uploader File

Description

In the createBookings function of the data uploader file, there seems to be an issue with the mapping of guestId. The variable allGuestIds is being populated using guestsIds.map((cabin) => cabin.id), but it appears that cabin.id is incorrect in this context. It should be guestsIds.map((guest) => guest.id).

Steps to Reproduce:

  1. Navigate to the createBookings function in the data uploader file.
  2. Observe the line: const allGuestIds = guestsIds.map((cabin) => cabin.id);
  3. Note that cabin.id is used to map guest IDs, which seems to be incorrect.

Expected Behavior:
The allGuestIds variable should be populated using the correct mapping, like so: const allGuestIds = guestsIds.map((guest) => guest.id);

Quokka.js cis been not supported

const book = getBook(2);

const title =book.title;
title; The Cyberiad;

#12 finding bug in section 3 and Quokka.js cant worked and they cant be compiled
issue

[07-usepopcorn]Issue with event listener cleanup in useEffect

file: app-v3.js
line-179,180

The code snippet provided seems to have a problem with the cleanup of the event listener in the useEffect hook. In the cleanup function, the event listener is added again instead of being removed using removeEventListener. This can lead to unexpected behavior and potential memory leaks.

Proposed Solution: Modify the cleanup function in the useEffect hook to properly remove the event listener using removeEventListener. Also, include inputEl.current in the dependency array to handle changes to inputEl.current correctly.
issue

consloe Error

when i want to dispatch some action in my app i get an error A component is changing an uncontrolled input to be controlled

lesson 36 pizza image is not loaded

Follow code in lesson 36 and browser does not display any images

lesson code:

image

fix:
<img
src={process.env.PUBLIC_URL + "pizzas/spinaci.jpg"}
alt="Pizza spinaci"
/>

Typo on slide 39 of theory-slides.pdf

Hi Jonas,

There is a typo on slide 39 from the PDF "theory-slides.pdf", where instead of "FOR SETTING UP A RECT PROJECT", it should be "REACT".

截屏2023-11-01 23 40 31

Thanks for building up such a wonderful course,
Cheers

css bug in travel-list

Hi, I'm following the tutorial on the Udemy. The css file gives me a large white space down there. Everything above the white space is html element. So I suspect height: 100vh doesn't work properly. But I'm not a css expert and cannot figure out how to fix it. I tried on Firefox but having the same issue.
image

Problem installing `npm i redux-devtools-extension`

Chapter 20, section 13 instructs to run npm i redux-devtools-extension.

This returned the following error on my machine however.

npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR!
npm ERR! While resolving: [email protected]
npm ERR! Found: [email protected]
npm ERR! node_modules/redux
npm ERR!   redux@"^5.0.1" from the root project
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer redux@"^3.1.0 || ^4.0.0" from [email protected]
npm ERR! node_modules/redux-devtools-extension
npm ERR!   redux-devtools-extension@"*" from the root project
npm ERR!
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.

Replacing my package.json by the final version solved this issue.

Chapter 10 video 119 Improving reusability with props

The StarRating component currently expects a function to be passed to the onSetRating prop. If this prop is not provided, the application throws an error when trying to execute onSetRating as it is undefined. The StarRating component should have a default behavior defined for onSetRating to avoid TypeError when the function is not provided. This will enhance the component's robustness and prevent potential runtime errors. I found this error for the movie list app in Star component. . Please check it and add this verificator for avoiding questions about it 😁

function handleRating(rating) { setRating(rating); if(onSetRating) onSetRating(rating); }

PropType validation error in CityList.jsx and CityItem.jsx in WorldWise project

If you are following and coding along, you might have come across this error yourself as well, i.e in the Implementing the Cities video.
When you try to pass the city prop to the CityItem.jsx component then you might have come up with this error where it is asking to specify the types of prop that you are passing.

country' is missing in props validation react/prop-types
7:22 error 'country.emoji' is missing in props validation react/prop-types
8:22 error 'country.emoji' is missing in props validation react/prop-types

It is turning out to be like this and for the time being, I have added prop types for each props being passed. If anyone has succesfully resolve this error. Please do leave any resources/ comment that could help me.

Thanks and regards

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.